fix: fix some ui displays and features miss implemented

crates/domain/tests/serde_roundtrip.rs

@@ -6,7 +6,7 @@ mod helpers;
 use domain::{
     Agent, AgentManifest, AgentOrigin, AgentProfile, AgentTemplate, ContextInjection, Direction,
     LayoutNode, LayoutTree, LeafCell, ManifestEntry, MarkdownDoc, Project, ProjectPath, RemoteRef,
-    SplitContainer, SshAuth, TemplateVersion, WeightedChild,
+    Skill, SkillId, SkillRef, SkillScope, SplitContainer, SshAuth, TemplateVersion, WeightedChild,
 };
 use helpers::{node, session};
 use uuid::Uuid;
@@ -229,6 +229,61 @@ fn manifest_roundtrip_and_camel_case() {
     assert!(!json.contains("\"templateId\":null"), "json was {json}");
 }
 
+// ---------------------------------------------------------------------------
+// Skill (L12) — round-trip, camelCase scope tag, manifest skills back-compat
+// ---------------------------------------------------------------------------
+
+fn sid(n: u128) -> SkillId {
+    SkillId::from_uuid(Uuid::from_u128(n))
+}
+
+#[test]
+fn skill_roundtrip_and_camel_case_scope() {
+    let s = Skill::new(sid(1), "code-review", MarkdownDoc::new("body"), SkillScope::Global).unwrap();
+    assert_eq!(roundtrip(&s), s);
+    let json = serde_json::to_string(&s).unwrap();
+    assert!(json.contains("\"scope\":\"global\""), "json was {json}");
+    assert!(json.contains("\"contentMd\""), "json was {json}");
+
+    let p = Skill::new(sid(2), "simplify", MarkdownDoc::new("b"), SkillScope::Project).unwrap();
+    let pj = serde_json::to_string(&p).unwrap();
+    assert!(pj.contains("\"scope\":\"project\""), "json was {pj}");
+}
+
+#[test]
+fn manifest_entry_skills_roundtrip_and_camel_case() {
+    let entry = ManifestEntry::from_agent(
+        &Agent::new(
+            aid(1),
+            "dev",
+            "agents/dev.md",
+            profid(9),
+            AgentOrigin::Scratch,
+            false,
+        )
+        .unwrap()
+        .with_skills(vec![SkillRef::new(sid(5), SkillScope::Project)]),
+    );
+    assert_eq!(roundtrip(&entry), entry);
+    let json = serde_json::to_string(&entry).unwrap();
+    assert!(json.contains("\"skillId\""), "json was {json}");
+    assert!(json.contains("\"scope\":\"project\""), "json was {json}");
+}
+
+#[test]
+fn manifest_entry_without_skills_omits_field_and_deserialises() {
+    // An entry with no skills must not emit "skills" (skip_serializing_if),
+    // and a pre-L12 manifest JSON (no skills key) must deserialise to empty.
+    let entry =
+        ManifestEntry::new(aid(1), "dev", "agents/dev.md", profid(9), None, false, None).unwrap();
+    let json = serde_json::to_string(&entry).unwrap();
+    assert!(!json.contains("\"skills\""), "json was {json}");
+
+    let legacy = r#"{"agentId":"00000000-0000-0000-0000-000000000001","name":"dev","mdPath":"agents/dev.md","profileId":"00000000-0000-0000-0000-000000000009","synchronized":false}"#;
+    let parsed: ManifestEntry = serde_json::from_str(legacy).unwrap();
+    assert!(parsed.skills.is_empty());
+}
+
 // ---------------------------------------------------------------------------
 // LayoutTree (tagged enum: type/node)
 // ---------------------------------------------------------------------------