fix(cli): arrêt du spinner Progress à l'état terminal — #157 (QA verte)
Ajoute completeRunningProgress() qui passe les stages started/delta à completed lors des événements final/error. La ligne Progress conserve son contenu statique utile mais n'affiche plus l'animation de chargement une fois le tour terminé. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
@ -1,4 +1,4 @@
|
|||||||
import { fireEvent, render, screen, waitFor } from "@testing-library/react";
|
import { act, fireEvent, render, screen, waitFor } from "@testing-library/react";
|
||||||
import { useState } from "react";
|
import { useState } from "react";
|
||||||
import { describe, expect, it, vi } from "vitest";
|
import { describe, expect, it, vi } from "vitest";
|
||||||
|
|
||||||
@ -296,6 +296,90 @@ describe("CustomAgentChatView", () => {
|
|||||||
await screen.findByText("done");
|
await screen.findByText("done");
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("stops animating running progress rows once the turn reaches a final chunk", async () => {
|
||||||
|
let emitChunk: ((chunk: unknown) => void) | null = null;
|
||||||
|
const agent = {
|
||||||
|
launchAgentChat: vi.fn(),
|
||||||
|
reattachAgentChat: vi.fn(async (sessionId: string) => ({
|
||||||
|
sessionId,
|
||||||
|
scrollback: [],
|
||||||
|
})),
|
||||||
|
sendAgentChat: vi.fn(
|
||||||
|
(_sessionId: string, _prompt: string, onChunk: (chunk: unknown) => void) =>
|
||||||
|
new Promise<void>((resolve) => {
|
||||||
|
emitChunk = (chunk: unknown) => {
|
||||||
|
onChunk(chunk);
|
||||||
|
if ((chunk as { kind?: string }).kind === "final") resolve();
|
||||||
|
};
|
||||||
|
}),
|
||||||
|
),
|
||||||
|
cancelAgentChat: vi.fn(async () => {}),
|
||||||
|
closeAgentChat: vi.fn(async () => {}),
|
||||||
|
};
|
||||||
|
|
||||||
|
render(
|
||||||
|
<DIProvider
|
||||||
|
gateways={{
|
||||||
|
agent,
|
||||||
|
system: { pickFile: vi.fn(async () => null) },
|
||||||
|
} as unknown as Gateways}
|
||||||
|
>
|
||||||
|
<CustomAgentChatView
|
||||||
|
projectId="project-1"
|
||||||
|
agentId="agent-1"
|
||||||
|
agentName="Worker"
|
||||||
|
profile={profile}
|
||||||
|
cwd="/repo"
|
||||||
|
nodeId="node-1"
|
||||||
|
sessionId="chat-session-1"
|
||||||
|
conversationId="conversation-1"
|
||||||
|
onSessionId={vi.fn()}
|
||||||
|
onConversationId={vi.fn()}
|
||||||
|
/>
|
||||||
|
</DIProvider>,
|
||||||
|
);
|
||||||
|
|
||||||
|
await waitFor(() =>
|
||||||
|
expect(agent.reattachAgentChat).toHaveBeenCalledWith(
|
||||||
|
"chat-session-1",
|
||||||
|
expect.any(Function),
|
||||||
|
),
|
||||||
|
);
|
||||||
|
|
||||||
|
fireEvent.change(screen.getByLabelText(/message CLI custom/), {
|
||||||
|
target: { value: "ship progress UI" },
|
||||||
|
});
|
||||||
|
fireEvent.click(screen.getByRole("button", { name: "Envoyer" }));
|
||||||
|
await waitFor(() => expect(emitChunk).not.toBeNull());
|
||||||
|
|
||||||
|
act(() => {
|
||||||
|
emitChunk?.({
|
||||||
|
kind: "progress",
|
||||||
|
progress: {
|
||||||
|
source: "providerNative",
|
||||||
|
kind: "message",
|
||||||
|
stage: "delta",
|
||||||
|
label: "Analyse",
|
||||||
|
text: "Lecture du contexte disponible.",
|
||||||
|
},
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(screen.getAllByRole("status", { name: "Loading" }).length).toBeGreaterThan(0);
|
||||||
|
expect(screen.getByText("Progress").parentElement?.textContent).toContain("running");
|
||||||
|
|
||||||
|
act(() => {
|
||||||
|
emitChunk?.({ kind: "final", content: "done" });
|
||||||
|
});
|
||||||
|
|
||||||
|
await screen.findByText("done");
|
||||||
|
await waitFor(() =>
|
||||||
|
expect(screen.queryByRole("status", { name: "Loading" })).toBeNull(),
|
||||||
|
);
|
||||||
|
expect(screen.getByText("Lecture du contexte disponible.")).toBeTruthy();
|
||||||
|
expect(screen.getByText("Progress").parentElement?.textContent).toContain("done");
|
||||||
|
});
|
||||||
|
|
||||||
it("pastes a clipboard image as a removable preview chip", async () => {
|
it("pastes a clipboard image as a removable preview chip", async () => {
|
||||||
const agent = {
|
const agent = {
|
||||||
launchAgentChat: vi.fn(),
|
launchAgentChat: vi.fn(),
|
||||||
|
|||||||
@ -191,6 +191,24 @@ function appendProgress(turns: ChatTurn[], progress: ReplyProgress): ChatTurn[]
|
|||||||
return [...turns, { role: "progress", progress }];
|
return [...turns, { role: "progress", progress }];
|
||||||
}
|
}
|
||||||
|
|
||||||
|
function completeRunningProgress(turns: ChatTurn[]): ChatTurn[] {
|
||||||
|
return turns.map((turn) => {
|
||||||
|
if (
|
||||||
|
turn.role !== "progress" ||
|
||||||
|
(turn.progress.stage !== "started" && turn.progress.stage !== "delta")
|
||||||
|
) {
|
||||||
|
return turn;
|
||||||
|
}
|
||||||
|
return {
|
||||||
|
...turn,
|
||||||
|
progress: {
|
||||||
|
...turn.progress,
|
||||||
|
stage: "completed",
|
||||||
|
},
|
||||||
|
};
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
function fileExtension(mime: string): string {
|
function fileExtension(mime: string): string {
|
||||||
if (mime === "image/png") return "png";
|
if (mime === "image/png") return "png";
|
||||||
if (mime === "image/jpeg") return "jpg";
|
if (mime === "image/jpeg") return "jpg";
|
||||||
@ -257,14 +275,14 @@ function foldChunk(turns: ChatTurn[], raw: unknown): ChatTurn[] {
|
|||||||
}
|
}
|
||||||
case "final": {
|
case "final": {
|
||||||
const content = String(raw.content ?? "");
|
const content = String(raw.content ?? "");
|
||||||
const next = [...turns];
|
const next = completeRunningProgress(turns);
|
||||||
const last = next[next.length - 1];
|
const last = next[next.length - 1];
|
||||||
if (last?.role === "agent") next[next.length - 1] = { ...last, pending: false };
|
if (last?.role === "agent") next[next.length - 1] = { ...last, pending: false };
|
||||||
next.push({ role: "final", text: content });
|
next.push({ role: "final", text: content });
|
||||||
return next;
|
return next;
|
||||||
}
|
}
|
||||||
case "error": {
|
case "error": {
|
||||||
const next = [...turns];
|
const next = completeRunningProgress(turns);
|
||||||
const last = next[next.length - 1];
|
const last = next[next.length - 1];
|
||||||
if (last?.role === "agent") next[next.length - 1] = { ...last, pending: false };
|
if (last?.role === "agent") next[next.length - 1] = { ...last, pending: false };
|
||||||
next.push({ role: "error", text: String(raw.message ?? "Erreur agent") });
|
next.push({ role: "error", text: String(raw.message ?? "Erreur agent") });
|
||||||
|
|||||||
Reference in New Issue
Block a user