merge(backend,application,frontend,domain,web-server,app-tauri): feature #317 — bouton Redémarrer l'agent dans la barre des cellules (QA verte)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
@ -26,11 +26,12 @@ use application::{
|
|||||||
ReadAgentContextInput, ReadConversationPageInput, ReadMcpToolPermissionsInput,
|
ReadAgentContextInput, ReadConversationPageInput, ReadMcpToolPermissionsInput,
|
||||||
ReadMemoryIndexInput, ReadProjectContextInput, RecallMemoryInput, RenameDeviceInput,
|
ReadMemoryIndexInput, ReadProjectContextInput, RecallMemoryInput, RenameDeviceInput,
|
||||||
RenameLayoutInput, ResolveAgentPermissionsInput, ResolveAgentSystemPermissionsInput,
|
RenameLayoutInput, ResolveAgentPermissionsInput, ResolveAgentSystemPermissionsInput,
|
||||||
ResolveMemoryLinksInput, RevokeDeviceInput, RotateConversationLogInput, SaveChatDraftInput,
|
ResolveMemoryLinksInput, RestartCellAgentRuntimeInput, RevokeDeviceInput,
|
||||||
SetActiveLayoutInput, SetAgentMcpToolAllowedInput, SlashCommandEffect,
|
RotateConversationLogInput, SaveChatDraftInput, SetActiveLayoutInput,
|
||||||
SnapshotRunningAgentsInput, StopLiveAgentInput, SyncAgentWithTemplateInput,
|
SetAgentMcpToolAllowedInput, SlashCommandEffect, SnapshotRunningAgentsInput,
|
||||||
UnassignSkillFromAgentInput, UpdateAgentContactableInput, UpdateAgentContextInput,
|
StopLiveAgentInput, SyncAgentWithTemplateInput, UnassignSkillFromAgentInput,
|
||||||
UpdateAgentEffortInput, UpdateAgentMcpToolPermissionsInput, UpdateAgentPermissionsInput,
|
UpdateAgentContactableInput, UpdateAgentContextInput, UpdateAgentEffortInput,
|
||||||
|
UpdateAgentMcpToolPermissionsInput, UpdateAgentPermissionsInput,
|
||||||
UpdateAgentSystemPermissionsInput, UpdateMemoryInput, UpdateProjectContextInput,
|
UpdateAgentSystemPermissionsInput, UpdateMemoryInput, UpdateProjectContextInput,
|
||||||
UpdateProjectMcpToolPermissionsInput, UpdateProjectOrchestratorInput,
|
UpdateProjectMcpToolPermissionsInput, UpdateProjectOrchestratorInput,
|
||||||
UpdateProjectPermissionsInput, UpdateProjectSystemPermissionsInput, UpdateSkillInput,
|
UpdateProjectPermissionsInput, UpdateProjectSystemPermissionsInput, UpdateSkillInput,
|
||||||
@ -73,6 +74,7 @@ use crate::dto::{
|
|||||||
RemoveProjectResponseDto, RenameLayoutRequestDto, ReplyChunk, ResizeTerminalRequestDto,
|
RemoveProjectResponseDto, RenameLayoutRequestDto, ReplyChunk, ResizeTerminalRequestDto,
|
||||||
ResolveAgentPermissionsRequestDto, ResolveAgentPermissionsResponseDto,
|
ResolveAgentPermissionsRequestDto, ResolveAgentPermissionsResponseDto,
|
||||||
ResolveAgentSystemPermissionsRequestDto, ResolvedAgentSystemPermissionsDto,
|
ResolveAgentSystemPermissionsRequestDto, ResolvedAgentSystemPermissionsDto,
|
||||||
|
RestartCellAgentRuntimeRequestDto, RestartCellAgentRuntimeResponseDto,
|
||||||
RestoreOpenProjectsOutputDto, ResumableAgentListDto, RetryOpenProjectRestoreRequestDto,
|
RestoreOpenProjectsOutputDto, ResumableAgentListDto, RetryOpenProjectRestoreRequestDto,
|
||||||
SaveChatDraftRequestDto, SaveEmbedderProfileRequestDto, SaveModelServerRequestDto,
|
SaveChatDraftRequestDto, SaveEmbedderProfileRequestDto, SaveModelServerRequestDto,
|
||||||
SaveOpenCodeProviderProfileRequestDto, SaveOpenProjectRestoreOrderRequestDto,
|
SaveOpenCodeProviderProfileRequestDto, SaveOpenProjectRestoreOrderRequestDto,
|
||||||
@ -2268,6 +2270,32 @@ pub async fn stop_live_agent(
|
|||||||
.map_err(ErrorDto::from)
|
.map_err(ErrorDto::from)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// Atomically restarts the runtime bound to an exact visible agent cell.
|
||||||
|
///
|
||||||
|
/// The presentation hint is retained for correlation only. Runtime selection,
|
||||||
|
/// stop ordering and relaunch are owned by the backend restart coordinator.
|
||||||
|
#[tauri::command]
|
||||||
|
pub async fn restart_cell_agent_runtime(
|
||||||
|
request: RestartCellAgentRuntimeRequestDto,
|
||||||
|
state: State<'_, AppState>,
|
||||||
|
) -> Result<RestartCellAgentRuntimeResponseDto, ErrorDto> {
|
||||||
|
let project = resolve_project(&request.project_id, &state).await?;
|
||||||
|
let output = state
|
||||||
|
.restart_cell_agent_runtime
|
||||||
|
.execute(RestartCellAgentRuntimeInput {
|
||||||
|
project,
|
||||||
|
node_id: parse_node_id(&request.node_id)?,
|
||||||
|
agent_id: parse_agent_id(&request.agent_id)?,
|
||||||
|
presentation: request.presentation.into(),
|
||||||
|
layout_id: request
|
||||||
|
.layout_id
|
||||||
|
.as_deref()
|
||||||
|
.map(parse_layout_id)
|
||||||
|
.transpose()?,
|
||||||
|
})?;
|
||||||
|
Ok(output.into())
|
||||||
|
}
|
||||||
|
|
||||||
/// `read_agent_context` — read an agent's Markdown context.
|
/// `read_agent_context` — read an agent's Markdown context.
|
||||||
///
|
///
|
||||||
/// # Errors
|
/// # Errors
|
||||||
|
|||||||
@ -351,6 +351,7 @@ pub fn run() {
|
|||||||
commands::list_live_agents,
|
commands::list_live_agents,
|
||||||
commands::attach_live_agent,
|
commands::attach_live_agent,
|
||||||
commands::stop_live_agent,
|
commands::stop_live_agent,
|
||||||
|
commands::restart_cell_agent_runtime,
|
||||||
commands::read_agent_context,
|
commands::read_agent_context,
|
||||||
commands::update_agent_context,
|
commands::update_agent_context,
|
||||||
commands::delete_agent,
|
commands::delete_agent,
|
||||||
|
|||||||
@ -741,3 +741,53 @@ fn stop_live_agent_response_serialises_camelcase_with_kind() {
|
|||||||
assert_eq!(v["alreadyStopped"], false);
|
assert_eq!(v["alreadyStopped"], false);
|
||||||
assert!(v.get("session_id").is_none());
|
assert!(v.get("session_id").is_none());
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn restart_cell_agent_request_deserialises_all_presentations() {
|
||||||
|
use app_tauri_lib::dto::{CellAgentPresentationDto, RestartCellAgentRuntimeRequestDto};
|
||||||
|
|
||||||
|
for (wire, expected) in [
|
||||||
|
("headless", CellAgentPresentationDto::Headless),
|
||||||
|
("tui", CellAgentPresentationDto::Tui),
|
||||||
|
("customCli", CellAgentPresentationDto::CustomCli),
|
||||||
|
("unknown", CellAgentPresentationDto::Unknown),
|
||||||
|
] {
|
||||||
|
let raw = json!({
|
||||||
|
"projectId": Uuid::from_u128(1).to_string(),
|
||||||
|
"nodeId": Uuid::from_u128(2).to_string(),
|
||||||
|
"agentId": Uuid::from_u128(3).to_string(),
|
||||||
|
"presentation": wire,
|
||||||
|
"layoutId": Uuid::from_u128(4).to_string()
|
||||||
|
});
|
||||||
|
let dto: RestartCellAgentRuntimeRequestDto = serde_json::from_value(raw).unwrap();
|
||||||
|
assert_eq!(dto.presentation, expected);
|
||||||
|
assert_eq!(dto.layout_id, Some(Uuid::from_u128(4).to_string()));
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn restart_cell_agent_response_uses_restart_event_correlation_contract() {
|
||||||
|
use app_tauri_lib::dto::RestartCellAgentRuntimeResponseDto;
|
||||||
|
use application::{CellAgentPresentation, LiveSessionKind, RestartCellAgentRuntimeOutput};
|
||||||
|
|
||||||
|
let agent = AgentId::from_uuid(Uuid::from_u128(11));
|
||||||
|
let node = NodeId::from_uuid(Uuid::from_u128(12));
|
||||||
|
let layout = domain::LayoutId::from_uuid(Uuid::from_u128(13));
|
||||||
|
let dto = RestartCellAgentRuntimeResponseDto::from(RestartCellAgentRuntimeOutput {
|
||||||
|
restart_id: "restart-317".to_owned(),
|
||||||
|
agent_id: agent,
|
||||||
|
node_id: node,
|
||||||
|
kind: LiveSessionKind::Structured,
|
||||||
|
presentation: CellAgentPresentation::CustomCli,
|
||||||
|
layout_id: Some(layout),
|
||||||
|
});
|
||||||
|
|
||||||
|
let value = serde_json::to_value(dto).unwrap();
|
||||||
|
assert_eq!(value["restartId"], "restart-317");
|
||||||
|
assert_eq!(value["status"], "scheduled");
|
||||||
|
assert_eq!(value["agentId"], agent.to_string());
|
||||||
|
assert_eq!(value["nodeId"], node.to_string());
|
||||||
|
assert_eq!(value["kind"], "structured");
|
||||||
|
assert_eq!(value["presentation"], "customCli");
|
||||||
|
assert_eq!(value["layoutId"], layout.to_string());
|
||||||
|
}
|
||||||
|
|||||||
@ -73,6 +73,36 @@ pub enum AppError {
|
|||||||
node_id: NodeId,
|
node_id: NodeId,
|
||||||
},
|
},
|
||||||
|
|
||||||
|
/// No live runtime can be restarted for the requested agent.
|
||||||
|
#[error("runtime not found for agent {agent_id}")]
|
||||||
|
RestartRuntimeNotFound {
|
||||||
|
/// Agent whose runtime was requested.
|
||||||
|
agent_id: AgentId,
|
||||||
|
},
|
||||||
|
|
||||||
|
/// The requested cell does not host the requested live agent runtime.
|
||||||
|
#[error("agent {agent_id} is not bound to cell {node_id}")]
|
||||||
|
AgentNotBoundToCell {
|
||||||
|
/// Agent supplied by the caller.
|
||||||
|
agent_id: AgentId,
|
||||||
|
/// Cell supplied by the caller.
|
||||||
|
node_id: NodeId,
|
||||||
|
},
|
||||||
|
|
||||||
|
/// More than one live runtime/cell currently represents the same agent.
|
||||||
|
#[error("agent {agent_id} is visible in more than one live cell")]
|
||||||
|
ConflictAgentVisibleElsewhere {
|
||||||
|
/// Ambiguous agent.
|
||||||
|
agent_id: AgentId,
|
||||||
|
},
|
||||||
|
|
||||||
|
/// Runtime teardown did not reach its terminal boundary in time.
|
||||||
|
#[error("timed out while stopping agent {agent_id} for restart")]
|
||||||
|
RestartStopTimeout {
|
||||||
|
/// Agent whose old runtime could not be stopped conclusively.
|
||||||
|
agent_id: AgentId,
|
||||||
|
},
|
||||||
|
|
||||||
/// The delegation target finished its structured/headless turn without producing
|
/// The delegation target finished its structured/headless turn without producing
|
||||||
/// a [`ReplyEvent::Final`](domain::ports::ReplyEvent::Final), so the rendezvous
|
/// a [`ReplyEvent::Final`](domain::ports::ReplyEvent::Final), so the rendezvous
|
||||||
/// could not capture an inline answer. Surfaced promptly instead of blocking the
|
/// could not capture an inline answer. Surfaced promptly instead of blocking the
|
||||||
@ -120,6 +150,10 @@ impl AppError {
|
|||||||
Self::Git(_) => "GIT",
|
Self::Git(_) => "GIT",
|
||||||
Self::Remote(_) => "REMOTE",
|
Self::Remote(_) => "REMOTE",
|
||||||
Self::AgentAlreadyRunning { .. } => "AGENT_ALREADY_RUNNING",
|
Self::AgentAlreadyRunning { .. } => "AGENT_ALREADY_RUNNING",
|
||||||
|
Self::RestartRuntimeNotFound { .. } => "RUNTIME_NOT_FOUND",
|
||||||
|
Self::AgentNotBoundToCell { .. } => "AGENT_NOT_BOUND_TO_CELL",
|
||||||
|
Self::ConflictAgentVisibleElsewhere { .. } => "CONFLICT_AGENT_VISIBLE_ELSEWHERE",
|
||||||
|
Self::RestartStopTimeout { .. } => "STOP_TIMEOUT",
|
||||||
Self::TargetReturnedNoReply(_) => "TARGET_RETURNED_NO_REPLY",
|
Self::TargetReturnedNoReply(_) => "TARGET_RETURNED_NO_REPLY",
|
||||||
Self::TargetCeilingActive(_) => "RENDEZVOUS_CEILING_ACTIVE",
|
Self::TargetCeilingActive(_) => "RENDEZVOUS_CEILING_ACTIVE",
|
||||||
Self::Internal(_) => "INTERNAL",
|
Self::Internal(_) => "INTERNAL",
|
||||||
|
|||||||
@ -280,11 +280,13 @@ pub use window::{
|
|||||||
pub use workstate::{
|
pub use workstate::{
|
||||||
AgentBackgroundTaskState, AgentTicketState, AgentWorkState, AppExitWorkGuardDetail,
|
AgentBackgroundTaskState, AgentTicketState, AgentWorkState, AppExitWorkGuardDetail,
|
||||||
AppExitWorkGuardState, AttachLiveAgent, AttachLiveAgentInput, AttachLiveAgentOutput,
|
AppExitWorkGuardState, AttachLiveAgent, AttachLiveAgentInput, AttachLiveAgentOutput,
|
||||||
BackgroundTaskKindLabel, ConversationLogProvider, ConversationPreviewStatus,
|
BackgroundTaskKindLabel, CellAgentPresentation, ConversationLogProvider,
|
||||||
ConversationTurnWorkPreview, ConversationWorkSummary, GetAppExitWorkGuardState,
|
ConversationPreviewStatus, ConversationTurnWorkPreview, ConversationWorkSummary,
|
||||||
GetAppExitWorkGuardStateInput, GetLiveStateLean, GetProjectWorkState, GetProjectWorkStateInput,
|
GetAppExitWorkGuardState, GetAppExitWorkGuardStateInput, GetLiveStateLean, GetProjectWorkState,
|
||||||
LeanLiveEntry, LeanLiveState, LiveWorkSession, ProjectWorkState, ReconcileLiveState,
|
GetProjectWorkStateInput, LeanLiveEntry, LeanLiveState, LiveWorkSession, ProjectWorkState,
|
||||||
ReconcileLiveStateInput, StopAgentExecutionCascade, StopAgentRuntime, StopLiveAgent,
|
ReconcileLiveState, ReconcileLiveStateInput, RestartCellAgentRuntime,
|
||||||
StopLiveAgentInput, StopLiveAgentOutput, TicketWorkSource, TicketWorkStatus, UpdateLiveState,
|
RestartCellAgentRuntimeInput, RestartCellAgentRuntimeOutput, StopAgentExecutionCascade,
|
||||||
UpdateLiveStateInput, LIVE_STATE_MAX_ENTRIES, LIVE_STATE_TTL_MS,
|
StopAgentRuntime, StopLiveAgent, StopLiveAgentInput, StopLiveAgentOutput, TicketWorkSource,
|
||||||
|
TicketWorkStatus, UpdateLiveState, UpdateLiveStateInput, LIVE_STATE_MAX_ENTRIES,
|
||||||
|
LIVE_STATE_TTL_MS,
|
||||||
};
|
};
|
||||||
|
|||||||
@ -32,7 +32,7 @@ use domain::ports::{
|
|||||||
use domain::project::ProjectPath;
|
use domain::project::ProjectPath;
|
||||||
use domain::{
|
use domain::{
|
||||||
AgentId, AgentProfile, BackgroundTask, BackgroundTaskKind, BackgroundTaskRendezvousLink,
|
AgentId, AgentProfile, BackgroundTask, BackgroundTaskKind, BackgroundTaskRendezvousLink,
|
||||||
BackgroundTaskResult, BackgroundTaskState, BackgroundTaskWakePolicy, DomainEvent,
|
BackgroundTaskResult, BackgroundTaskState, BackgroundTaskWakePolicy, DomainEvent, NodeId,
|
||||||
OrchestratorCommand, OrchestratorVisibility, ProfileId, Project, RendezvousId, RuntimeAgentKey,
|
OrchestratorCommand, OrchestratorVisibility, ProfileId, Project, RendezvousId, RuntimeAgentKey,
|
||||||
TaskId,
|
TaskId,
|
||||||
};
|
};
|
||||||
@ -83,6 +83,20 @@ pub trait AgentSelfRestartScheduler: Send + Sync {
|
|||||||
agent: AgentId,
|
agent: AgentId,
|
||||||
reason: Option<String>,
|
reason: Option<String>,
|
||||||
) -> Result<AgentRestartScheduled, AppError>;
|
) -> Result<AgentRestartScheduled, AppError>;
|
||||||
|
|
||||||
|
/// Schedules the same restart while pinning it to a caller-validated cell.
|
||||||
|
/// Implementations must revalidate the binding atomically with their
|
||||||
|
/// concurrency guard before accepting the request.
|
||||||
|
fn schedule_cell(
|
||||||
|
&self,
|
||||||
|
project: &Project,
|
||||||
|
agent: AgentId,
|
||||||
|
node: NodeId,
|
||||||
|
reason: Option<String>,
|
||||||
|
) -> Result<AgentRestartScheduled, AppError> {
|
||||||
|
let _ = node;
|
||||||
|
self.schedule(project, agent, reason)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Internal continuation prompt used when a self-restart is handed back to the
|
/// Internal continuation prompt used when a self-restart is handed back to the
|
||||||
|
|||||||
@ -12,10 +12,10 @@ use std::sync::Arc;
|
|||||||
use async_trait::async_trait;
|
use async_trait::async_trait;
|
||||||
use domain::input::InputMediator;
|
use domain::input::InputMediator;
|
||||||
use domain::live_state::WorkStatus;
|
use domain::live_state::WorkStatus;
|
||||||
use domain::{AgentId, NodeId, Project, RuntimeAgentKey, SessionId};
|
use domain::{AgentId, LayoutId, NodeId, Project, RuntimeAgentKey, SessionId};
|
||||||
|
|
||||||
use crate::error::AppError;
|
use crate::error::AppError;
|
||||||
use crate::orchestrator::{LiveStateProvider, OrchestratorService};
|
use crate::orchestrator::{AgentSelfRestartScheduler, LiveStateProvider, OrchestratorService};
|
||||||
use crate::terminal::{
|
use crate::terminal::{
|
||||||
stop_live_agent_runtime_in_project, CloseTerminal, LiveSessionKind, LiveSessions,
|
stop_live_agent_runtime_in_project, CloseTerminal, LiveSessionKind, LiveSessions,
|
||||||
};
|
};
|
||||||
@ -122,6 +122,113 @@ pub struct StopLiveAgentOutput {
|
|||||||
pub already_stopped: bool,
|
pub already_stopped: bool,
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// Caller-side indication of how the hosting cell presents the agent.
|
||||||
|
///
|
||||||
|
/// This value is never trusted to select the runtime: the live registries and
|
||||||
|
/// the launch context remain authoritative.
|
||||||
|
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
||||||
|
pub enum CellAgentPresentation {
|
||||||
|
/// Agent driven without an interactive human surface.
|
||||||
|
Headless,
|
||||||
|
/// Native provider terminal/TUI.
|
||||||
|
Tui,
|
||||||
|
/// IdeA structured/custom CLI chat.
|
||||||
|
CustomCli,
|
||||||
|
/// Older caller that cannot identify its presentation.
|
||||||
|
Unknown,
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Input for [`RestartCellAgentRuntime::execute`].
|
||||||
|
#[derive(Debug, Clone, PartialEq, Eq)]
|
||||||
|
pub struct RestartCellAgentRuntimeInput {
|
||||||
|
/// Owning project resolved by the driving adapter.
|
||||||
|
pub project: Project,
|
||||||
|
/// Exact leaf whose runtime is being restarted.
|
||||||
|
pub node_id: NodeId,
|
||||||
|
/// Agent expected to be bound to `node_id`.
|
||||||
|
pub agent_id: AgentId,
|
||||||
|
/// Informational UI presentation; never used as runtime truth.
|
||||||
|
pub presentation: CellAgentPresentation,
|
||||||
|
/// Optional layout identity supplied by clients that already have it.
|
||||||
|
pub layout_id: Option<LayoutId>,
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Immediate acknowledgement for an accepted atomic cell restart.
|
||||||
|
#[derive(Debug, Clone, PartialEq, Eq)]
|
||||||
|
pub struct RestartCellAgentRuntimeOutput {
|
||||||
|
/// Restart correlation id used by the existing restart event stream.
|
||||||
|
pub restart_id: String,
|
||||||
|
/// Validated agent identity.
|
||||||
|
pub agent_id: AgentId,
|
||||||
|
/// Validated hosting node.
|
||||||
|
pub node_id: NodeId,
|
||||||
|
/// Actual runtime family resolved from the live registry.
|
||||||
|
pub kind: LiveSessionKind,
|
||||||
|
/// Informational presentation echoed for caller correlation.
|
||||||
|
pub presentation: CellAgentPresentation,
|
||||||
|
/// Optional layout identity echoed for caller correlation.
|
||||||
|
pub layout_id: Option<LayoutId>,
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Atomically validates a cell/runtime binding and schedules its replacement
|
||||||
|
/// through IdeA's existing restart coordinator.
|
||||||
|
pub struct RestartCellAgentRuntime {
|
||||||
|
live: Arc<LiveSessions>,
|
||||||
|
scheduler: Arc<dyn AgentSelfRestartScheduler>,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl RestartCellAgentRuntime {
|
||||||
|
/// Builds the use case over the authoritative runtime registry and restart seam.
|
||||||
|
#[must_use]
|
||||||
|
pub fn new(live: Arc<LiveSessions>, scheduler: Arc<dyn AgentSelfRestartScheduler>) -> Self {
|
||||||
|
Self { live, scheduler }
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Validates the exact live binding before the scheduler repeats that check
|
||||||
|
/// under its per-agent concurrency guard and accepts the detached restart.
|
||||||
|
pub fn execute(
|
||||||
|
&self,
|
||||||
|
input: RestartCellAgentRuntimeInput,
|
||||||
|
) -> Result<RestartCellAgentRuntimeOutput, AppError> {
|
||||||
|
let snapshots = self
|
||||||
|
.live
|
||||||
|
.live_agent_snapshots_for(input.project.id, &input.agent_id);
|
||||||
|
let snapshot = match snapshots.as_slice() {
|
||||||
|
[] => {
|
||||||
|
return Err(AppError::RestartRuntimeNotFound {
|
||||||
|
agent_id: input.agent_id,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
[snapshot] => *snapshot,
|
||||||
|
_ => {
|
||||||
|
return Err(AppError::ConflictAgentVisibleElsewhere {
|
||||||
|
agent_id: input.agent_id,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
};
|
||||||
|
if snapshot.node_id != input.node_id {
|
||||||
|
return Err(AppError::AgentNotBoundToCell {
|
||||||
|
agent_id: input.agent_id,
|
||||||
|
node_id: input.node_id,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
let scheduled = self.scheduler.schedule_cell(
|
||||||
|
&input.project,
|
||||||
|
input.agent_id,
|
||||||
|
input.node_id,
|
||||||
|
Some("redémarrage demandé depuis la cellule".to_owned()),
|
||||||
|
)?;
|
||||||
|
Ok(RestartCellAgentRuntimeOutput {
|
||||||
|
restart_id: scheduled.restart_id,
|
||||||
|
agent_id: input.agent_id,
|
||||||
|
node_id: input.node_id,
|
||||||
|
kind: snapshot.kind,
|
||||||
|
presentation: input.presentation,
|
||||||
|
layout_id: input.layout_id,
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
/// Best-effort stopper for execution resources owned by one live agent turn.
|
/// Best-effort stopper for execution resources owned by one live agent turn.
|
||||||
///
|
///
|
||||||
/// Implementations must be idempotent: a missing, already-finished or already-stopped
|
/// Implementations must be idempotent: a missing, already-finished or already-stopped
|
||||||
|
|||||||
@ -10,8 +10,10 @@ mod live;
|
|||||||
mod reconcile;
|
mod reconcile;
|
||||||
|
|
||||||
pub use actions::{
|
pub use actions::{
|
||||||
AttachLiveAgent, AttachLiveAgentInput, AttachLiveAgentOutput, StopAgentExecutionCascade,
|
AttachLiveAgent, AttachLiveAgentInput, AttachLiveAgentOutput, CellAgentPresentation,
|
||||||
StopAgentRuntime, StopLiveAgent, StopLiveAgentInput, StopLiveAgentOutput,
|
RestartCellAgentRuntime, RestartCellAgentRuntimeInput, RestartCellAgentRuntimeOutput,
|
||||||
|
StopAgentExecutionCascade, StopAgentRuntime, StopLiveAgent, StopLiveAgentInput,
|
||||||
|
StopLiveAgentOutput,
|
||||||
};
|
};
|
||||||
pub use live::{
|
pub use live::{
|
||||||
GetLiveStateLean, LeanLiveEntry, LeanLiveState, UpdateLiveState, UpdateLiveStateInput,
|
GetLiveStateLean, LeanLiveEntry, LeanLiveState, UpdateLiveState, UpdateLiveStateInput,
|
||||||
|
|||||||
@ -11,9 +11,10 @@ use std::sync::{Arc, Mutex};
|
|||||||
use async_trait::async_trait;
|
use async_trait::async_trait;
|
||||||
|
|
||||||
use application::{
|
use application::{
|
||||||
AttachLiveAgent, AttachLiveAgentInput, CloseTerminal, LiveRuntimeState, LiveSessionKind,
|
AgentRestartScheduled, AgentSelfRestartScheduler, AppError, AttachLiveAgent,
|
||||||
LiveSessions, StopAgentExecutionCascade, StopLiveAgent, StopLiveAgentInput, StructuredSessions,
|
AttachLiveAgentInput, CellAgentPresentation, CloseTerminal, LiveRuntimeState, LiveSessionKind,
|
||||||
TerminalSessions,
|
LiveSessions, RestartCellAgentRuntime, RestartCellAgentRuntimeInput, StopAgentExecutionCascade,
|
||||||
|
StopLiveAgent, StopLiveAgentInput, StructuredSessions, TerminalSessions,
|
||||||
};
|
};
|
||||||
use domain::ports::{
|
use domain::ports::{
|
||||||
AgentSession, AgentSessionError, ExitStatus, OutputStream, PtyError, PtyHandle, PtyPort,
|
AgentSession, AgentSessionError, ExitStatus, OutputStream, PtyError, PtyHandle, PtyPort,
|
||||||
@ -21,7 +22,7 @@ use domain::ports::{
|
|||||||
};
|
};
|
||||||
use domain::Project;
|
use domain::Project;
|
||||||
use domain::{
|
use domain::{
|
||||||
AgentId, NodeId, ProjectId, ProjectPath, PtySize, RemoteRef, SessionId, SessionKind,
|
AgentId, LayoutId, NodeId, ProjectId, ProjectPath, PtySize, RemoteRef, SessionId, SessionKind,
|
||||||
TerminalSession,
|
TerminalSession,
|
||||||
};
|
};
|
||||||
use uuid::Uuid;
|
use uuid::Uuid;
|
||||||
@ -131,6 +132,35 @@ struct FakeCascade {
|
|||||||
calls: Mutex<Vec<(ProjectId, AgentId)>>,
|
calls: Mutex<Vec<(ProjectId, AgentId)>>,
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[derive(Default)]
|
||||||
|
struct FakeRestartScheduler {
|
||||||
|
calls: Mutex<Vec<(ProjectId, AgentId, NodeId)>>,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl AgentSelfRestartScheduler for FakeRestartScheduler {
|
||||||
|
fn schedule(
|
||||||
|
&self,
|
||||||
|
_project: &Project,
|
||||||
|
_agent: AgentId,
|
||||||
|
_reason: Option<String>,
|
||||||
|
) -> Result<AgentRestartScheduled, AppError> {
|
||||||
|
unreachable!("cell restart must use the cell-aware scheduler seam")
|
||||||
|
}
|
||||||
|
|
||||||
|
fn schedule_cell(
|
||||||
|
&self,
|
||||||
|
project: &Project,
|
||||||
|
agent: AgentId,
|
||||||
|
node: NodeId,
|
||||||
|
_reason: Option<String>,
|
||||||
|
) -> Result<AgentRestartScheduled, AppError> {
|
||||||
|
self.calls.lock().unwrap().push((project.id, agent, node));
|
||||||
|
Ok(AgentRestartScheduled {
|
||||||
|
restart_id: "restart-cell-test".to_owned(),
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
#[async_trait]
|
#[async_trait]
|
||||||
impl StopAgentExecutionCascade for FakeCascade {
|
impl StopAgentExecutionCascade for FakeCascade {
|
||||||
async fn stop_agent_execution_children(&self, project: &Project, agent_id: AgentId) {
|
async fn stop_agent_execution_children(&self, project: &Project, agent_id: AgentId) {
|
||||||
@ -148,6 +178,8 @@ struct Fixture {
|
|||||||
pty: Arc<TerminalSessions>,
|
pty: Arc<TerminalSessions>,
|
||||||
structured: Arc<StructuredSessions>,
|
structured: Arc<StructuredSessions>,
|
||||||
pty_port: Arc<FakePty>,
|
pty_port: Arc<FakePty>,
|
||||||
|
restart: RestartCellAgentRuntime,
|
||||||
|
restart_scheduler: Arc<FakeRestartScheduler>,
|
||||||
}
|
}
|
||||||
|
|
||||||
fn fixture() -> Fixture {
|
fn fixture() -> Fixture {
|
||||||
@ -159,12 +191,32 @@ fn fixture() -> Fixture {
|
|||||||
Arc::clone(&pty_port) as Arc<dyn PtyPort>,
|
Arc::clone(&pty_port) as Arc<dyn PtyPort>,
|
||||||
Arc::clone(&pty),
|
Arc::clone(&pty),
|
||||||
));
|
));
|
||||||
|
let restart_scheduler = Arc::new(FakeRestartScheduler::default());
|
||||||
Fixture {
|
Fixture {
|
||||||
attach: AttachLiveAgent::new(Arc::clone(&live)),
|
attach: AttachLiveAgent::new(Arc::clone(&live)),
|
||||||
stop: StopLiveAgent::new(Arc::clone(&live), close),
|
stop: StopLiveAgent::new(Arc::clone(&live), close),
|
||||||
pty,
|
pty,
|
||||||
structured,
|
structured,
|
||||||
pty_port,
|
pty_port,
|
||||||
|
restart: RestartCellAgentRuntime::new(
|
||||||
|
Arc::clone(&live),
|
||||||
|
Arc::clone(&restart_scheduler) as Arc<dyn AgentSelfRestartScheduler>,
|
||||||
|
),
|
||||||
|
restart_scheduler,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
fn restart_input(
|
||||||
|
agent_id: AgentId,
|
||||||
|
node_id: NodeId,
|
||||||
|
presentation: CellAgentPresentation,
|
||||||
|
) -> RestartCellAgentRuntimeInput {
|
||||||
|
RestartCellAgentRuntimeInput {
|
||||||
|
project: project(),
|
||||||
|
node_id,
|
||||||
|
agent_id,
|
||||||
|
presentation,
|
||||||
|
layout_id: Some(LayoutId::from_uuid(Uuid::from_u128(500))),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -315,6 +367,106 @@ fn attach_same_node_is_idempotent() {
|
|||||||
assert_eq!(f.pty.len(), 1, "no extra session created");
|
assert_eq!(f.pty.len(), 1, "no extra session created");
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// ---------------------------------------------------------------------------
|
||||||
|
// RestartCellAgentRuntime
|
||||||
|
// ---------------------------------------------------------------------------
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn restart_cell_accepts_tui_and_preserves_exact_binding() {
|
||||||
|
let f = fixture();
|
||||||
|
let agent = aid(10);
|
||||||
|
let node = nid(100);
|
||||||
|
insert_pty(&f.pty, sid(1), agent, node);
|
||||||
|
|
||||||
|
let out = f
|
||||||
|
.restart
|
||||||
|
.execute(restart_input(agent, node, CellAgentPresentation::Tui))
|
||||||
|
.unwrap();
|
||||||
|
|
||||||
|
assert_eq!(out.restart_id, "restart-cell-test");
|
||||||
|
assert_eq!(out.agent_id, agent);
|
||||||
|
assert_eq!(out.node_id, node);
|
||||||
|
assert_eq!(out.kind, LiveSessionKind::Pty);
|
||||||
|
assert_eq!(out.presentation, CellAgentPresentation::Tui);
|
||||||
|
assert_eq!(
|
||||||
|
*f.restart_scheduler.calls.lock().unwrap(),
|
||||||
|
vec![(project().id, agent, node)]
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn restart_cell_accepts_structured_custom_cli_and_headless_hints() {
|
||||||
|
for presentation in [
|
||||||
|
CellAgentPresentation::CustomCli,
|
||||||
|
CellAgentPresentation::Headless,
|
||||||
|
] {
|
||||||
|
let f = fixture();
|
||||||
|
let agent = aid(10);
|
||||||
|
let node = nid(100);
|
||||||
|
insert_structured(&f.structured, sid(2), agent, node);
|
||||||
|
|
||||||
|
let out = f
|
||||||
|
.restart
|
||||||
|
.execute(restart_input(agent, node, presentation))
|
||||||
|
.unwrap();
|
||||||
|
|
||||||
|
assert_eq!(out.kind, LiveSessionKind::Structured);
|
||||||
|
assert_eq!(out.presentation, presentation);
|
||||||
|
assert_eq!(f.restart_scheduler.calls.lock().unwrap().len(), 1);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn restart_cell_rejects_stale_agent_or_node_without_scheduling() {
|
||||||
|
let f = fixture();
|
||||||
|
let agent = aid(10);
|
||||||
|
insert_pty(&f.pty, sid(1), agent, nid(100));
|
||||||
|
|
||||||
|
let error = f
|
||||||
|
.restart
|
||||||
|
.execute(restart_input(
|
||||||
|
agent,
|
||||||
|
nid(999),
|
||||||
|
CellAgentPresentation::Unknown,
|
||||||
|
))
|
||||||
|
.unwrap_err();
|
||||||
|
|
||||||
|
assert_eq!(error.code(), "AGENT_NOT_BOUND_TO_CELL");
|
||||||
|
assert!(f.restart_scheduler.calls.lock().unwrap().is_empty());
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn restart_cell_rejects_missing_runtime_without_scheduling() {
|
||||||
|
let f = fixture();
|
||||||
|
let error = f
|
||||||
|
.restart
|
||||||
|
.execute(restart_input(
|
||||||
|
aid(999),
|
||||||
|
nid(100),
|
||||||
|
CellAgentPresentation::Unknown,
|
||||||
|
))
|
||||||
|
.unwrap_err();
|
||||||
|
|
||||||
|
assert_eq!(error.code(), "RUNTIME_NOT_FOUND");
|
||||||
|
assert!(f.restart_scheduler.calls.lock().unwrap().is_empty());
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn restart_cell_rejects_agent_visible_in_multiple_live_cells() {
|
||||||
|
let f = fixture();
|
||||||
|
let agent = aid(10);
|
||||||
|
insert_pty(&f.pty, sid(1), agent, nid(100));
|
||||||
|
insert_structured(&f.structured, sid(2), agent, nid(200));
|
||||||
|
|
||||||
|
let error = f
|
||||||
|
.restart
|
||||||
|
.execute(restart_input(agent, nid(100), CellAgentPresentation::Tui))
|
||||||
|
.unwrap_err();
|
||||||
|
|
||||||
|
assert_eq!(error.code(), "CONFLICT_AGENT_VISIBLE_ELSEWHERE");
|
||||||
|
assert!(f.restart_scheduler.calls.lock().unwrap().is_empty());
|
||||||
|
}
|
||||||
|
|
||||||
// ---------------------------------------------------------------------------
|
// ---------------------------------------------------------------------------
|
||||||
// StopLiveAgent
|
// StopLiveAgent
|
||||||
// ---------------------------------------------------------------------------
|
// ---------------------------------------------------------------------------
|
||||||
|
|||||||
@ -12,13 +12,14 @@ use serde_json::Value;
|
|||||||
|
|
||||||
use application::{
|
use application::{
|
||||||
AgentBackgroundTaskState, AgentTicketState, AppError, AppExitWorkGuardDetail,
|
AgentBackgroundTaskState, AgentTicketState, AppError, AppExitWorkGuardDetail,
|
||||||
AppExitWorkGuardState, AttachLiveAgentOutput, BackgroundTaskKindLabel,
|
AppExitWorkGuardState, AttachLiveAgentOutput, BackgroundTaskKindLabel, CellAgentPresentation,
|
||||||
ConversationPreviewStatus, ConversationTurnWorkPreview, ConversationWorkSummary,
|
ConversationPreviewStatus, ConversationTurnWorkPreview, ConversationWorkSummary,
|
||||||
CreateProjectInput, CreateProjectOutput, ExecuteSlashCommandOutput, GitGraphOutput,
|
CreateProjectInput, CreateProjectOutput, ExecuteSlashCommandOutput, GitGraphOutput,
|
||||||
HealthInput, HealthReport, LayoutKind, ListProjectsOutput, ListSlashCommandsOutput,
|
HealthInput, HealthReport, LayoutKind, ListProjectsOutput, ListSlashCommandsOutput,
|
||||||
LiveRuntimeState, LiveSessionKind, LiveSessionSnapshot, OpenProjectOutput, ProjectWorkState,
|
LiveRuntimeState, LiveSessionKind, LiveSessionSnapshot, OpenProjectOutput, ProjectWorkState,
|
||||||
RestoreOpenProjectFailure, RestoreOpenProjectsOutput, SlashCommandEffect, StopLiveAgentOutput,
|
RestartCellAgentRuntimeOutput, RestoreOpenProjectFailure, RestoreOpenProjectsOutput,
|
||||||
TicketWorkSource, TicketWorkStatus, TurnPage, TurnSource, TurnView,
|
SlashCommandEffect, StopLiveAgentOutput, TicketWorkSource, TicketWorkStatus, TurnPage,
|
||||||
|
TurnSource, TurnView,
|
||||||
};
|
};
|
||||||
use domain::ports::{ReplyProgress, ReplyProgressKind, ReplyProgressSource, ReplyProgressStage};
|
use domain::ports::{ReplyProgress, ReplyProgressKind, ReplyProgressSource, ReplyProgressStage};
|
||||||
use domain::{
|
use domain::{
|
||||||
@ -4611,6 +4612,98 @@ pub struct StopLiveAgentRequestDto {
|
|||||||
pub reason: Option<String>,
|
pub reason: Option<String>,
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// Informational presentation supplied by the cell that requests a restart.
|
||||||
|
#[derive(Debug, Clone, Copy, PartialEq, Eq, Serialize, Deserialize)]
|
||||||
|
#[serde(rename_all = "camelCase")]
|
||||||
|
pub enum CellAgentPresentationDto {
|
||||||
|
/// Background/headless orchestration surface.
|
||||||
|
Headless,
|
||||||
|
/// Native interactive provider terminal.
|
||||||
|
Tui,
|
||||||
|
/// IdeA structured/custom CLI chat.
|
||||||
|
CustomCli,
|
||||||
|
/// Presentation cannot be determined by the caller.
|
||||||
|
Unknown,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl From<CellAgentPresentationDto> for CellAgentPresentation {
|
||||||
|
fn from(value: CellAgentPresentationDto) -> Self {
|
||||||
|
match value {
|
||||||
|
CellAgentPresentationDto::Headless => Self::Headless,
|
||||||
|
CellAgentPresentationDto::Tui => Self::Tui,
|
||||||
|
CellAgentPresentationDto::CustomCli => Self::CustomCli,
|
||||||
|
CellAgentPresentationDto::Unknown => Self::Unknown,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
impl From<CellAgentPresentation> for CellAgentPresentationDto {
|
||||||
|
fn from(value: CellAgentPresentation) -> Self {
|
||||||
|
match value {
|
||||||
|
CellAgentPresentation::Headless => Self::Headless,
|
||||||
|
CellAgentPresentation::Tui => Self::Tui,
|
||||||
|
CellAgentPresentation::CustomCli => Self::CustomCli,
|
||||||
|
CellAgentPresentation::Unknown => Self::Unknown,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Request for an atomic restart of the runtime bound to one agent cell.
|
||||||
|
#[derive(Debug, Clone, Deserialize)]
|
||||||
|
#[serde(rename_all = "camelCase")]
|
||||||
|
pub struct RestartCellAgentRuntimeRequestDto {
|
||||||
|
/// Owning project registry id.
|
||||||
|
pub project_id: String,
|
||||||
|
/// Exact hosting layout leaf.
|
||||||
|
pub node_id: String,
|
||||||
|
/// Agent expected to be bound to the leaf.
|
||||||
|
pub agent_id: String,
|
||||||
|
/// Informational presentation; the backend resolves the real runtime.
|
||||||
|
#[serde(default = "unknown_cell_agent_presentation")]
|
||||||
|
pub presentation: CellAgentPresentationDto,
|
||||||
|
/// Optional named layout id when already known by the caller.
|
||||||
|
#[serde(default)]
|
||||||
|
pub layout_id: Option<String>,
|
||||||
|
}
|
||||||
|
|
||||||
|
fn unknown_cell_agent_presentation() -> CellAgentPresentationDto {
|
||||||
|
CellAgentPresentationDto::Unknown
|
||||||
|
}
|
||||||
|
|
||||||
|
/// Immediate acknowledgement for an accepted cell restart.
|
||||||
|
#[derive(Debug, Clone, Serialize)]
|
||||||
|
#[serde(rename_all = "camelCase")]
|
||||||
|
pub struct RestartCellAgentRuntimeResponseDto {
|
||||||
|
/// Correlation id used by `agentRestart*` events.
|
||||||
|
pub restart_id: String,
|
||||||
|
/// Stable acknowledgement state.
|
||||||
|
pub status: &'static str,
|
||||||
|
/// Validated agent id.
|
||||||
|
pub agent_id: String,
|
||||||
|
/// Validated node id.
|
||||||
|
pub node_id: String,
|
||||||
|
/// Actual live runtime family (`pty` or `structured`).
|
||||||
|
pub kind: LiveWorkSessionKindDto,
|
||||||
|
/// Informational presentation echoed to the caller.
|
||||||
|
pub presentation: CellAgentPresentationDto,
|
||||||
|
/// Optional layout id echoed to the caller.
|
||||||
|
pub layout_id: Option<String>,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl From<RestartCellAgentRuntimeOutput> for RestartCellAgentRuntimeResponseDto {
|
||||||
|
fn from(out: RestartCellAgentRuntimeOutput) -> Self {
|
||||||
|
Self {
|
||||||
|
restart_id: out.restart_id,
|
||||||
|
status: "scheduled",
|
||||||
|
agent_id: out.agent_id.to_string(),
|
||||||
|
node_id: out.node_id.to_string(),
|
||||||
|
kind: out.kind.into(),
|
||||||
|
presentation: out.presentation.into(),
|
||||||
|
layout_id: out.layout_id.map(|id| id.to_string()),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
/// Response DTO for `stop_live_agent`: the torn-down session's coordinates.
|
/// Response DTO for `stop_live_agent`: the torn-down session's coordinates.
|
||||||
#[derive(Debug, Clone, Serialize)]
|
#[derive(Debug, Clone, Serialize)]
|
||||||
#[serde(rename_all = "camelCase")]
|
#[serde(rename_all = "camelCase")]
|
||||||
|
|||||||
@ -139,6 +139,7 @@ pub enum DomainEventDto {
|
|||||||
agent_id: String,
|
agent_id: String,
|
||||||
restart_id: String,
|
restart_id: String,
|
||||||
phase: String,
|
phase: String,
|
||||||
|
code: String,
|
||||||
message: String,
|
message: String,
|
||||||
},
|
},
|
||||||
/// A project was created.
|
/// A project was created.
|
||||||
@ -844,11 +845,13 @@ impl From<&DomainEvent> for DomainEventDto {
|
|||||||
agent_id,
|
agent_id,
|
||||||
restart_id,
|
restart_id,
|
||||||
phase,
|
phase,
|
||||||
|
code,
|
||||||
message,
|
message,
|
||||||
} => Self::AgentRestartFailed {
|
} => Self::AgentRestartFailed {
|
||||||
agent_id: agent_id.to_string(),
|
agent_id: agent_id.to_string(),
|
||||||
restart_id: restart_id.clone(),
|
restart_id: restart_id.clone(),
|
||||||
phase: restart_phase_label(*phase).to_owned(),
|
phase: restart_phase_label(*phase).to_owned(),
|
||||||
|
code: code.clone(),
|
||||||
message: message.clone(),
|
message: message.clone(),
|
||||||
},
|
},
|
||||||
DomainEvent::ProjectCreated { project_id } => Self::ProjectCreated {
|
DomainEvent::ProjectCreated { project_id } => Self::ProjectCreated {
|
||||||
@ -1427,11 +1430,13 @@ mod tests {
|
|||||||
agent_id: id,
|
agent_id: id,
|
||||||
restart_id: "restart-288".to_owned(),
|
restart_id: "restart-288".to_owned(),
|
||||||
phase: domain::events::AgentRestartPhase::Launching,
|
phase: domain::events::AgentRestartPhase::Launching,
|
||||||
|
code: "LAUNCH_FAILED".to_owned(),
|
||||||
message: "launch failed".to_owned(),
|
message: "launch failed".to_owned(),
|
||||||
});
|
});
|
||||||
let failed = serde_json::to_value(failed).expect("serialisable");
|
let failed = serde_json::to_value(failed).expect("serialisable");
|
||||||
assert_eq!(failed["type"], "agentRestartFailed");
|
assert_eq!(failed["type"], "agentRestartFailed");
|
||||||
assert_eq!(failed["phase"], "launching");
|
assert_eq!(failed["phase"], "launching");
|
||||||
|
assert_eq!(failed["code"], "LAUNCH_FAILED");
|
||||||
assert_eq!(failed["message"], "launch failed");
|
assert_eq!(failed["message"], "launch failed");
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@ -51,21 +51,22 @@ use application::{
|
|||||||
ReferenceProfiles, ReleaseManagedTemp, ReloadPlugin, ReloadPluginInput,
|
ReferenceProfiles, ReleaseManagedTemp, ReloadPlugin, ReloadPluginInput,
|
||||||
RemoveProjectFromRegistry, RenameDevice, RenameLayout, RenameSprint, ReorderSprints,
|
RemoveProjectFromRegistry, RenameDevice, RenameLayout, RenameSprint, ReorderSprints,
|
||||||
ResizeTerminal, ResolveAgentCapabilities, ResolveAgentPermissions,
|
ResizeTerminal, ResolveAgentCapabilities, ResolveAgentPermissions,
|
||||||
ResolveAgentSystemPermissions, ResolveManagedTemp, ResolveMemoryLinks, RestoreOpenProjects,
|
ResolveAgentSystemPermissions, ResolveManagedTemp, ResolveMemoryLinks, RestartCellAgentRuntime,
|
||||||
RestoreOpenProjectsOutput, RestoreOpenWindows, RetryBackgroundTask, RetryOpenProjectRestore,
|
RestoreOpenProjects, RestoreOpenProjectsOutput, RestoreOpenWindows, RetryBackgroundTask,
|
||||||
ReviewPluginPackage, RevokeAllDevices, RevokeDevice, RotateConversationLog, SaveChatDraft,
|
RetryOpenProjectRestore, ReviewPluginPackage, RevokeAllDevices, RevokeDevice,
|
||||||
SaveEmbedderProfile, SaveModelServer, SaveOpenCodeProviderProfile, SaveOpenProjectRestoreOrder,
|
RotateConversationLog, SaveChatDraft, SaveEmbedderProfile, SaveModelServer,
|
||||||
SaveProfile, ScheduledProjectTaskService, SessionLimitService, SetActiveLayout,
|
SaveOpenCodeProviderProfile, SaveOpenProjectRestoreOrder, SaveProfile,
|
||||||
SetAgentMcpToolAllowed, SetPluginEnabled, SetProjectPluginEnabled, SlashCommandRegistry,
|
ScheduledProjectTaskService, SessionLimitService, SetActiveLayout, SetAgentMcpToolAllowed,
|
||||||
SnapshotOpenWindows, SnapshotRunningAgents, SnapshotRunningAgentsInput, SpawnBackgroundCommand,
|
SetPluginEnabled, SetProjectPluginEnabled, SlashCommandRegistry, SnapshotOpenWindows,
|
||||||
StopAgentRuntime, StructuredRoutingMode, StructuredSessions, SuggestedThisSession,
|
SnapshotRunningAgents, SnapshotRunningAgentsInput, SpawnBackgroundCommand, StopAgentRuntime,
|
||||||
SyncAgentWithTemplate, TerminalSessions, TouchDevice, UnassignSkillFromAgent,
|
StructuredRoutingMode, StructuredSessions, SuggestedThisSession, SyncAgentWithTemplate,
|
||||||
UnassignTicketFromSprint, UninstallPlugin, UnlinkIssues, UpdateAgentContactable,
|
TerminalSessions, TouchDevice, UnassignSkillFromAgent, UnassignTicketFromSprint,
|
||||||
UpdateAgentContext, UpdateAgentEffort, UpdateAgentMcpToolPermissions, UpdateAgentPermissions,
|
UninstallPlugin, UnlinkIssues, UpdateAgentContactable, UpdateAgentContext, UpdateAgentEffort,
|
||||||
UpdateAgentSystemPermissions, UpdateIssue, UpdateIssueCarnet, UpdateLiveState, UpdateMemory,
|
UpdateAgentMcpToolPermissions, UpdateAgentPermissions, UpdateAgentSystemPermissions,
|
||||||
UpdateProjectContext, UpdateProjectMcpToolPermissions, UpdateProjectOrchestrator,
|
UpdateIssue, UpdateIssueCarnet, UpdateLiveState, UpdateMemory, UpdateProjectContext,
|
||||||
UpdateProjectPermissions, UpdateProjectSettings, UpdateProjectSystemPermissions, UpdateSkill,
|
UpdateProjectMcpToolPermissions, UpdateProjectOrchestrator, UpdateProjectPermissions,
|
||||||
UpdateTemplate, UpdateUserSettings, WakeSessionProvider, WriteMemory, WriteToTerminal,
|
UpdateProjectSettings, UpdateProjectSystemPermissions, UpdateSkill, UpdateTemplate,
|
||||||
|
UpdateUserSettings, WakeSessionProvider, WriteMemory, WriteToTerminal,
|
||||||
AGENT_MEMORY_RECALL_BUDGET,
|
AGENT_MEMORY_RECALL_BUDGET,
|
||||||
};
|
};
|
||||||
use async_trait::async_trait;
|
use async_trait::async_trait;
|
||||||
@ -1090,6 +1091,19 @@ struct AppAgentSelfRestarter {
|
|||||||
rendezvous: Arc<application::RestartRendezvousCoordinator>,
|
rendezvous: Arc<application::RestartRendezvousCoordinator>,
|
||||||
}
|
}
|
||||||
|
|
||||||
|
async fn await_cell_restart_stop<F, T>(
|
||||||
|
agent_id: AgentId,
|
||||||
|
timeout: std::time::Duration,
|
||||||
|
stop: F,
|
||||||
|
) -> Result<T, AppError>
|
||||||
|
where
|
||||||
|
F: std::future::Future<Output = Result<T, AppError>>,
|
||||||
|
{
|
||||||
|
tokio::time::timeout(timeout, stop)
|
||||||
|
.await
|
||||||
|
.map_err(|_| AppError::RestartStopTimeout { agent_id })?
|
||||||
|
}
|
||||||
|
|
||||||
fn self_restart_launch_input(
|
fn self_restart_launch_input(
|
||||||
context: ResumeContext,
|
context: ResumeContext,
|
||||||
agent_id: AgentId,
|
agent_id: AgentId,
|
||||||
@ -1215,6 +1229,41 @@ mod self_restart_contract_tests {
|
|||||||
assert!(!input.fresh_start);
|
assert!(!input.fresh_start);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn relaunch_preserves_native_tui_routing_and_cell_geometry() {
|
||||||
|
let project = Project::new(
|
||||||
|
ProjectId::from_uuid(Uuid::from_u128(317)),
|
||||||
|
"restart-tui",
|
||||||
|
domain::project::ProjectPath::new("/tmp/idea-restart-tui").unwrap(),
|
||||||
|
domain::remote::RemoteRef::local(),
|
||||||
|
0,
|
||||||
|
)
|
||||||
|
.unwrap();
|
||||||
|
let agent = AgentId::from_uuid(Uuid::from_u128(1));
|
||||||
|
let node = domain::NodeId::from_uuid(Uuid::from_u128(2));
|
||||||
|
let input = self_restart_launch_input(
|
||||||
|
ResumeContext {
|
||||||
|
project,
|
||||||
|
rows: 42,
|
||||||
|
cols: 132,
|
||||||
|
node_id: Some(node),
|
||||||
|
conversation_id: Some("conversation-tui".to_owned()),
|
||||||
|
require_structured: false,
|
||||||
|
},
|
||||||
|
agent,
|
||||||
|
None,
|
||||||
|
);
|
||||||
|
|
||||||
|
assert_eq!(input.node_id, Some(node));
|
||||||
|
assert_eq!((input.rows, input.cols), (42, 132));
|
||||||
|
assert_eq!(
|
||||||
|
input.terminal_interface,
|
||||||
|
Some(domain::DefaultAgentTerminalInterface::NativeTui)
|
||||||
|
);
|
||||||
|
assert!(!input.require_structured);
|
||||||
|
assert!(!input.fresh_start);
|
||||||
|
}
|
||||||
|
|
||||||
#[tokio::test]
|
#[tokio::test]
|
||||||
async fn human_turn_ignores_old_terminal_and_accepts_replacement() {
|
async fn human_turn_ignores_old_terminal_and_accepts_replacement() {
|
||||||
let mailbox = Arc::new(InMemoryMailbox::new());
|
let mailbox = Arc::new(InMemoryMailbox::new());
|
||||||
@ -1287,30 +1336,67 @@ mod self_restart_contract_tests {
|
|||||||
assert_eq!(input.busy_state(key), domain::input::AgentBusyState::Idle);
|
assert_eq!(input.busy_state(key), domain::input::AgentBusyState::Idle);
|
||||||
assert_eq!(mailbox.pending(&key), 0);
|
assert_eq!(mailbox.pending(&key), 0);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[tokio::test]
|
||||||
|
async fn cell_restart_stop_timeout_is_typed_and_never_reaches_the_next_step() {
|
||||||
|
let agent = AgentId::from_uuid(Uuid::from_u128(317));
|
||||||
|
let reached_after_stop = Arc::new(std::sync::atomic::AtomicBool::new(false));
|
||||||
|
let result: Result<(), AppError> = await_cell_restart_stop(
|
||||||
|
agent,
|
||||||
|
std::time::Duration::from_millis(1),
|
||||||
|
std::future::pending(),
|
||||||
|
)
|
||||||
|
.await;
|
||||||
|
if result.is_ok() {
|
||||||
|
reached_after_stop.store(true, std::sync::atomic::Ordering::SeqCst);
|
||||||
|
}
|
||||||
|
|
||||||
|
assert_eq!(result.unwrap_err().code(), "STOP_TIMEOUT");
|
||||||
|
assert!(!reached_after_stop.load(std::sync::atomic::Ordering::SeqCst));
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
impl AgentSelfRestartScheduler for AppAgentSelfRestarter {
|
impl AppAgentSelfRestarter {
|
||||||
fn schedule(
|
fn schedule_restart(
|
||||||
&self,
|
&self,
|
||||||
project: &Project,
|
project: &Project,
|
||||||
agent: AgentId,
|
agent: AgentId,
|
||||||
|
requested_node: Option<domain::NodeId>,
|
||||||
reason: Option<String>,
|
reason: Option<String>,
|
||||||
) -> Result<AgentRestartScheduled, AppError> {
|
) -> Result<AgentRestartScheduled, AppError> {
|
||||||
let key = domain::RuntimeAgentKey::new(project.id, agent);
|
let key = domain::RuntimeAgentKey::new(project.id, agent);
|
||||||
let snapshots = self.live.live_agent_snapshots_for(project.id, &agent);
|
let snapshots = self.live.live_agent_snapshots_for(project.id, &agent);
|
||||||
if snapshots.is_empty() {
|
if snapshots.is_empty() {
|
||||||
return Err(AppError::Invalid(format!(
|
return if requested_node.is_some() {
|
||||||
"requester agent {agent} is not live"
|
Err(AppError::RestartRuntimeNotFound { agent_id: agent })
|
||||||
)));
|
} else {
|
||||||
|
Err(AppError::Invalid(format!(
|
||||||
|
"requester agent {agent} is not live"
|
||||||
|
)))
|
||||||
|
};
|
||||||
|
}
|
||||||
|
if let Some(node_id) = requested_node {
|
||||||
|
if snapshots.len() != 1 {
|
||||||
|
return Err(AppError::ConflictAgentVisibleElsewhere { agent_id: agent });
|
||||||
|
}
|
||||||
|
if snapshots[0].node_id != node_id {
|
||||||
|
return Err(AppError::AgentNotBoundToCell {
|
||||||
|
agent_id: agent,
|
||||||
|
node_id,
|
||||||
|
});
|
||||||
|
}
|
||||||
}
|
}
|
||||||
{
|
{
|
||||||
let mut active = self.active.lock().map_err(|_| {
|
let mut active = self.active.lock().map_err(|_| {
|
||||||
AppError::Internal("agent restart registry lock poisoned".to_owned())
|
AppError::Internal("agent restart registry lock poisoned".to_owned())
|
||||||
})?;
|
})?;
|
||||||
if !active.insert(key) {
|
if !active.insert(key) {
|
||||||
return Err(AppError::Invalid(format!(
|
let message = format!("a restart is already scheduled for agent {agent}");
|
||||||
"a restart is already scheduled for agent {agent}"
|
return if requested_node.is_some() {
|
||||||
)));
|
Err(AppError::Conflict(message))
|
||||||
|
} else {
|
||||||
|
Err(AppError::Invalid(message))
|
||||||
|
};
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -1346,29 +1432,36 @@ impl AgentSelfRestartScheduler for AppAgentSelfRestarter {
|
|||||||
};
|
};
|
||||||
let context = contexts.lock().ok().and_then(|map| map.get(&key).cloned());
|
let context = contexts.lock().ok().and_then(|map| map.get(&key).cloned());
|
||||||
let snapshot = snapshots[0];
|
let snapshot = snapshots[0];
|
||||||
let context = context.unwrap_or(ResumeContext {
|
let mut context = context.unwrap_or(ResumeContext {
|
||||||
project: project.clone(),
|
project: project.clone(),
|
||||||
rows: 24,
|
rows: 24,
|
||||||
cols: 80,
|
cols: 80,
|
||||||
node_id: None,
|
node_id: Some(snapshot.node_id),
|
||||||
conversation_id: live
|
conversation_id: live
|
||||||
.structured
|
.structured
|
||||||
.meta_for_session(&snapshot.session_id)
|
.meta_for_session(&snapshot.session_id)
|
||||||
.and_then(|(_, _, _, conversation)| conversation),
|
.and_then(|(_, _, _, conversation)| conversation),
|
||||||
require_structured: snapshot.kind == application::LiveSessionKind::Structured,
|
require_structured: snapshot.kind == application::LiveSessionKind::Structured,
|
||||||
});
|
});
|
||||||
|
if let Some(node_id) = requested_node {
|
||||||
|
context.node_id = Some(node_id);
|
||||||
|
}
|
||||||
|
|
||||||
publish_phase(AgentRestartPhase::Stopping);
|
publish_phase(AgentRestartPhase::Stopping);
|
||||||
if !delegated {
|
if !delegated {
|
||||||
input.preempt(key);
|
input.preempt(key);
|
||||||
}
|
}
|
||||||
let stop_result = application::terminal::stop_live_agent_runtime_in_project(
|
let stop = application::terminal::stop_live_agent_runtime_in_project(
|
||||||
&project,
|
&project,
|
||||||
agent,
|
agent,
|
||||||
live.as_ref(),
|
live.as_ref(),
|
||||||
close_terminal.as_ref(),
|
close_terminal.as_ref(),
|
||||||
)
|
);
|
||||||
.await;
|
let stop_result = if requested_node.is_some() {
|
||||||
|
await_cell_restart_stop(agent, std::time::Duration::from_secs(10), stop).await
|
||||||
|
} else {
|
||||||
|
stop.await
|
||||||
|
};
|
||||||
|
|
||||||
publish_phase(AgentRestartPhase::ReleasingInput);
|
publish_phase(AgentRestartPhase::ReleasingInput);
|
||||||
if !delegated {
|
if !delegated {
|
||||||
@ -1382,10 +1475,19 @@ impl AgentSelfRestartScheduler for AppAgentSelfRestarter {
|
|||||||
if delegated {
|
if delegated {
|
||||||
rendezvous.fail(key, &restart_id_task, error.to_string());
|
rendezvous.fail(key, &restart_id_task, error.to_string());
|
||||||
}
|
}
|
||||||
|
let code = match (&error, phase) {
|
||||||
|
(AppError::RestartStopTimeout { .. }, _) => "STOP_TIMEOUT",
|
||||||
|
(_, AgentRestartPhase::Stopping | AgentRestartPhase::ReleasingInput) => {
|
||||||
|
"STOP_FAILED"
|
||||||
|
}
|
||||||
|
(_, AgentRestartPhase::Launching) => "LAUNCH_FAILED",
|
||||||
|
(_, AgentRestartPhase::Resuming) => "RESUME_FAILED",
|
||||||
|
};
|
||||||
events.publish(DomainEvent::AgentRestartFailed {
|
events.publish(DomainEvent::AgentRestartFailed {
|
||||||
agent_id: agent,
|
agent_id: agent,
|
||||||
restart_id: restart_id_task.clone(),
|
restart_id: restart_id_task.clone(),
|
||||||
phase,
|
phase,
|
||||||
|
code: code.to_owned(),
|
||||||
message: error.to_string(),
|
message: error.to_string(),
|
||||||
});
|
});
|
||||||
};
|
};
|
||||||
@ -1395,7 +1497,7 @@ impl AgentSelfRestartScheduler for AppAgentSelfRestarter {
|
|||||||
}
|
}
|
||||||
};
|
};
|
||||||
match stop_result {
|
match stop_result {
|
||||||
Ok(stopped) if !stopped.is_empty() => {}
|
Ok(stopped) if !stopped.is_empty() || requested_node.is_some() => {}
|
||||||
Ok(_) => {
|
Ok(_) => {
|
||||||
fail(
|
fail(
|
||||||
AgentRestartPhase::Stopping,
|
AgentRestartPhase::Stopping,
|
||||||
@ -1541,6 +1643,27 @@ impl AgentSelfRestartScheduler for AppAgentSelfRestarter {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
impl AgentSelfRestartScheduler for AppAgentSelfRestarter {
|
||||||
|
fn schedule(
|
||||||
|
&self,
|
||||||
|
project: &Project,
|
||||||
|
agent: AgentId,
|
||||||
|
reason: Option<String>,
|
||||||
|
) -> Result<AgentRestartScheduled, AppError> {
|
||||||
|
self.schedule_restart(project, agent, None, reason)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn schedule_cell(
|
||||||
|
&self,
|
||||||
|
project: &Project,
|
||||||
|
agent: AgentId,
|
||||||
|
node: domain::NodeId,
|
||||||
|
reason: Option<String>,
|
||||||
|
) -> Result<AgentRestartScheduled, AppError> {
|
||||||
|
self.schedule_restart(project, agent, Some(node), reason)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
/// Guard for a direct human turn sent to a structured agent session.
|
/// Guard for a direct human turn sent to a structured agent session.
|
||||||
///
|
///
|
||||||
/// Direct chat adapters (`agent_send`, web `chat.send`) still drive the provider
|
/// Direct chat adapters (`agent_send`, web `chat.send`) still drive the provider
|
||||||
@ -2111,6 +2234,8 @@ pub struct BackendCore {
|
|||||||
pub attach_live_agent: Arc<AttachLiveAgent>,
|
pub attach_live_agent: Arc<AttachLiveAgent>,
|
||||||
/// Tears down an already-running agent's live session by agent id (Lot D).
|
/// Tears down an already-running agent's live session by agent id (Lot D).
|
||||||
pub stop_live_agent: Arc<StopAgentRuntime>,
|
pub stop_live_agent: Arc<StopAgentRuntime>,
|
||||||
|
/// Atomically restarts the runtime bound to an exact visible agent cell.
|
||||||
|
pub restart_cell_agent_runtime: Arc<RestartCellAgentRuntime>,
|
||||||
/// Best-effort inspection of a conversation (last topic + token indicator)
|
/// Best-effort inspection of a conversation (last topic + token indicator)
|
||||||
/// for the resume popup (T7). Optional/extensible: backed by a `Vec` of
|
/// for the resume popup (T7). Optional/extensible: backed by a `Vec` of
|
||||||
/// [`domain::ports::SessionInspector`]s; an empty/missing match yields empty
|
/// [`domain::ports::SessionInspector`]s; an empty/missing match yields empty
|
||||||
@ -3976,6 +4101,10 @@ impl BackendCore {
|
|||||||
active: Arc::new(Mutex::new(HashSet::new())),
|
active: Arc::new(Mutex::new(HashSet::new())),
|
||||||
rendezvous: Arc::clone(&restart_rendezvous),
|
rendezvous: Arc::clone(&restart_rendezvous),
|
||||||
}) as Arc<dyn AgentSelfRestartScheduler>;
|
}) as Arc<dyn AgentSelfRestartScheduler>;
|
||||||
|
let restart_cell_agent_runtime = Arc::new(RestartCellAgentRuntime::new(
|
||||||
|
Arc::clone(&live_sessions),
|
||||||
|
Arc::clone(&self_restart),
|
||||||
|
));
|
||||||
// Drain du scheduler (§21.5-b) : à chaque réveil tiré, `TokioScheduler` pousse une
|
// Drain du scheduler (§21.5-b) : à chaque réveil tiré, `TokioScheduler` pousse une
|
||||||
// `ScheduledTask::ResumeAgent` ; on l'exécute via le service (relance + AgentResumed).
|
// `ScheduledTask::ResumeAgent` ; on l'exécute via le service (relance + AgentResumed).
|
||||||
// Patron `sweep_stalled` : spawner detache (pas `tokio::spawn` — `build`
|
// Patron `sweep_stalled` : spawner detache (pas `tokio::spawn` — `build`
|
||||||
@ -4333,6 +4462,7 @@ impl BackendCore {
|
|||||||
rotate_conversation_log,
|
rotate_conversation_log,
|
||||||
attach_live_agent,
|
attach_live_agent,
|
||||||
stop_live_agent,
|
stop_live_agent,
|
||||||
|
restart_cell_agent_runtime,
|
||||||
inspect_conversation,
|
inspect_conversation,
|
||||||
project_store,
|
project_store,
|
||||||
read_user_settings,
|
read_user_settings,
|
||||||
|
|||||||
@ -82,6 +82,8 @@ pub enum DomainEvent {
|
|||||||
restart_id: String,
|
restart_id: String,
|
||||||
/// Phase that failed.
|
/// Phase that failed.
|
||||||
phase: AgentRestartPhase,
|
phase: AgentRestartPhase,
|
||||||
|
/// Stable machine-readable failure code.
|
||||||
|
code: String,
|
||||||
/// Human-readable failure safe to expose in the UI.
|
/// Human-readable failure safe to expose in the UI.
|
||||||
message: String,
|
message: String,
|
||||||
},
|
},
|
||||||
|
|||||||
@ -100,6 +100,7 @@ use backend::dto::{
|
|||||||
RemoveOpenProjectRestoreEntryRequestDto, RemoveProjectRequestDto, RemoveProjectResponseDto,
|
RemoveOpenProjectRestoreEntryRequestDto, RemoveProjectRequestDto, RemoveProjectResponseDto,
|
||||||
RenameLayoutRequestDto, ResolveAgentPermissionsRequestDto, ResolveAgentPermissionsResponseDto,
|
RenameLayoutRequestDto, ResolveAgentPermissionsRequestDto, ResolveAgentPermissionsResponseDto,
|
||||||
ResolveAgentSystemPermissionsRequestDto, ResolvedAgentSystemPermissionsDto,
|
ResolveAgentSystemPermissionsRequestDto, ResolvedAgentSystemPermissionsDto,
|
||||||
|
RestartCellAgentRuntimeRequestDto, RestartCellAgentRuntimeResponseDto,
|
||||||
RestoreOpenProjectsOutputDto, ResumableAgentListDto, RetryOpenProjectRestoreRequestDto,
|
RestoreOpenProjectsOutputDto, ResumableAgentListDto, RetryOpenProjectRestoreRequestDto,
|
||||||
SaveEmbedderProfileRequestDto, SaveOpenCodeProviderProfileRequestDto,
|
SaveEmbedderProfileRequestDto, SaveOpenCodeProviderProfileRequestDto,
|
||||||
SaveOpenProjectRestoreOrderRequestDto, SaveProfileRequestDto, SetActiveLayoutRequestDto,
|
SaveOpenProjectRestoreOrderRequestDto, SaveProfileRequestDto, SetActiveLayoutRequestDto,
|
||||||
@ -3442,6 +3443,9 @@ async fn invoke(
|
|||||||
"list_resumable_agents" => invoke_list_resumable_agents(&request.args, &state.app).await,
|
"list_resumable_agents" => invoke_list_resumable_agents(&request.args, &state.app).await,
|
||||||
"attach_live_agent" => invoke_attach_live_agent(&request.args, &state.app).await,
|
"attach_live_agent" => invoke_attach_live_agent(&request.args, &state.app).await,
|
||||||
"stop_live_agent" => invoke_stop_live_agent(&request.args, &state.app).await,
|
"stop_live_agent" => invoke_stop_live_agent(&request.args, &state.app).await,
|
||||||
|
"restart_cell_agent_runtime" => {
|
||||||
|
invoke_restart_cell_agent_runtime(&request.args, &state.app).await
|
||||||
|
}
|
||||||
"create_agent" => invoke_create_agent(&request.args, &state.app).await,
|
"create_agent" => invoke_create_agent(&request.args, &state.app).await,
|
||||||
"change_agent_profile" => invoke_change_agent_profile(&request.args, &state.app).await,
|
"change_agent_profile" => invoke_change_agent_profile(&request.args, &state.app).await,
|
||||||
"read_agent_context" => invoke_read_agent_context(&request.args, &state.app).await,
|
"read_agent_context" => invoke_read_agent_context(&request.args, &state.app).await,
|
||||||
@ -4128,6 +4132,31 @@ async fn invoke_stop_live_agent(args: &Value, state: &BackendCore) -> Result<Val
|
|||||||
serde_json::to_value(output).map_err(serialization_error)
|
serde_json::to_value(output).map_err(serialization_error)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
async fn invoke_restart_cell_agent_runtime(
|
||||||
|
args: &Value,
|
||||||
|
state: &BackendCore,
|
||||||
|
) -> Result<Value, ErrorDto> {
|
||||||
|
let request =
|
||||||
|
required_request::<RestartCellAgentRuntimeRequestDto>("restart_cell_agent_runtime", args)?;
|
||||||
|
let project = resolve_project_readonly(&request.project_id, state).await?;
|
||||||
|
let output = state
|
||||||
|
.restart_cell_agent_runtime
|
||||||
|
.execute(application::RestartCellAgentRuntimeInput {
|
||||||
|
project,
|
||||||
|
node_id: parse_node_id(&request.node_id)?,
|
||||||
|
agent_id: parse_agent_id(&request.agent_id)?,
|
||||||
|
presentation: request.presentation.into(),
|
||||||
|
layout_id: request
|
||||||
|
.layout_id
|
||||||
|
.as_deref()
|
||||||
|
.map(parse_layout_id)
|
||||||
|
.transpose()?,
|
||||||
|
})
|
||||||
|
.map(RestartCellAgentRuntimeResponseDto::from)
|
||||||
|
.map_err(ErrorDto::from)?;
|
||||||
|
serde_json::to_value(output).map_err(serialization_error)
|
||||||
|
}
|
||||||
|
|
||||||
async fn invoke_create_agent(args: &Value, state: &BackendCore) -> Result<Value, ErrorDto> {
|
async fn invoke_create_agent(args: &Value, state: &BackendCore) -> Result<Value, ErrorDto> {
|
||||||
let request = required_request::<CreateAgentRequestDto>("create_agent", args)?;
|
let request = required_request::<CreateAgentRequestDto>("create_agent", args)?;
|
||||||
let project = resolve_project_readonly(&request.project_id, state).await?;
|
let project = resolve_project_readonly(&request.project_id, state).await?;
|
||||||
@ -10748,6 +10777,7 @@ mod tests {
|
|||||||
"list_resumable_agents",
|
"list_resumable_agents",
|
||||||
"attach_live_agent",
|
"attach_live_agent",
|
||||||
"stop_live_agent",
|
"stop_live_agent",
|
||||||
|
"restart_cell_agent_runtime",
|
||||||
"create_agent",
|
"create_agent",
|
||||||
"change_agent_profile",
|
"change_agent_profile",
|
||||||
"read_agent_context",
|
"read_agent_context",
|
||||||
|
|||||||
@ -97,6 +97,38 @@ describe("TauriAgentGateway invoke payloads", () => {
|
|||||||
expect(out.stopped[0]?.sessionId).toBe("session-4");
|
expect(out.stopped[0]?.sessionId).toBe("session-4");
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("restart_cell_agent_runtime forwards the exact cell presentation", async () => {
|
||||||
|
const response = {
|
||||||
|
restartId: "restart-1",
|
||||||
|
status: "scheduled",
|
||||||
|
agentId: "agent-2",
|
||||||
|
nodeId: "node-3",
|
||||||
|
kind: "structured",
|
||||||
|
presentation: "customCli",
|
||||||
|
layoutId: "layout-4",
|
||||||
|
};
|
||||||
|
invoke.mockResolvedValueOnce(response);
|
||||||
|
|
||||||
|
await expect(
|
||||||
|
new TauriAgentGateway().restartCellAgentRuntime({
|
||||||
|
projectId: "proj-1",
|
||||||
|
nodeId: "node-3",
|
||||||
|
agentId: "agent-2",
|
||||||
|
presentation: "customCli",
|
||||||
|
layoutId: "layout-4",
|
||||||
|
}),
|
||||||
|
).resolves.toEqual(response);
|
||||||
|
expect(invoke).toHaveBeenCalledWith("restart_cell_agent_runtime", {
|
||||||
|
request: {
|
||||||
|
projectId: "proj-1",
|
||||||
|
nodeId: "node-3",
|
||||||
|
agentId: "agent-2",
|
||||||
|
presentation: "customCli",
|
||||||
|
layoutId: "layout-4",
|
||||||
|
},
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
it("change_agent_profile wraps all five fields in the request DTO (camelCase)", async () => {
|
it("change_agent_profile wraps all five fields in the request DTO (camelCase)", async () => {
|
||||||
invoke.mockResolvedValueOnce({ agent: { id: "agent-2" } });
|
invoke.mockResolvedValueOnce({ agent: { id: "agent-2" } });
|
||||||
await new TauriAgentGateway().changeAgentProfile(
|
await new TauriAgentGateway().changeAgentProfile(
|
||||||
|
|||||||
@ -36,6 +36,8 @@ import type {
|
|||||||
OpenTerminalOptions,
|
OpenTerminalOptions,
|
||||||
ReattachAgentChatResult,
|
ReattachAgentChatResult,
|
||||||
ReattachResult,
|
ReattachResult,
|
||||||
|
RestartCellAgentRuntimeInput,
|
||||||
|
RestartCellAgentRuntimeScheduled,
|
||||||
SendAgentChatOptions,
|
SendAgentChatOptions,
|
||||||
StoppedLiveAgent,
|
StoppedLiveAgent,
|
||||||
TerminalHandle,
|
TerminalHandle,
|
||||||
@ -105,6 +107,14 @@ export class TauriAgentGateway implements AgentGateway {
|
|||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
|
restartCellAgentRuntime(
|
||||||
|
input: RestartCellAgentRuntimeInput,
|
||||||
|
): Promise<RestartCellAgentRuntimeScheduled> {
|
||||||
|
return invoke<RestartCellAgentRuntimeScheduled>("restart_cell_agent_runtime", {
|
||||||
|
request: input,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
createAgent(projectId: string, input: CreateAgentInput): Promise<Agent> {
|
createAgent(projectId: string, input: CreateAgentInput): Promise<Agent> {
|
||||||
// The `create_agent` command takes a single `request` DTO; `projectId` must
|
// The `create_agent` command takes a single `request` DTO; `projectId` must
|
||||||
// live *inside* it (camelCase), not at the top level.
|
// live *inside* it (camelCase), not at the top level.
|
||||||
|
|||||||
@ -141,6 +141,45 @@ describe("HttpAgentGateway WS round-trip (B6 frames)", () => {
|
|||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it("restarts the exact cell runtime through the HTTP command", async () => {
|
||||||
|
const response = {
|
||||||
|
restartId: "restart-7",
|
||||||
|
status: "scheduled",
|
||||||
|
agentId: "agent-1",
|
||||||
|
nodeId: "node-2",
|
||||||
|
kind: "pty",
|
||||||
|
presentation: "tui",
|
||||||
|
layoutId: null,
|
||||||
|
};
|
||||||
|
const { gw, calls } = httpAgentGateway(async () => ({
|
||||||
|
ok: true,
|
||||||
|
status: 200,
|
||||||
|
json: async () => response,
|
||||||
|
text: async () => JSON.stringify(response),
|
||||||
|
}));
|
||||||
|
|
||||||
|
await expect(
|
||||||
|
gw.restartCellAgentRuntime({
|
||||||
|
projectId: "proj-1",
|
||||||
|
nodeId: "node-2",
|
||||||
|
agentId: "agent-1",
|
||||||
|
presentation: "tui",
|
||||||
|
}),
|
||||||
|
).resolves.toEqual(response);
|
||||||
|
const init = calls[0].init as { body: string };
|
||||||
|
expect(JSON.parse(init.body)).toEqual({
|
||||||
|
command: "restart_cell_agent_runtime",
|
||||||
|
args: {
|
||||||
|
request: {
|
||||||
|
projectId: "proj-1",
|
||||||
|
nodeId: "node-2",
|
||||||
|
agentId: "agent-1",
|
||||||
|
presentation: "tui",
|
||||||
|
},
|
||||||
|
},
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
it("updates the project orchestrator through the dedicated request DTO", async () => {
|
it("updates the project orchestrator through the dedicated request DTO", async () => {
|
||||||
const response = { orchestratorAgentId: "agent-2" };
|
const response = { orchestratorAgentId: "agent-2" };
|
||||||
const { gw, calls } = httpAgentGateway(async () => ({
|
const { gw, calls } = httpAgentGateway(async () => ({
|
||||||
|
|||||||
@ -53,6 +53,8 @@ import type {
|
|||||||
OpenTerminalOptions,
|
OpenTerminalOptions,
|
||||||
ReattachAgentChatResult,
|
ReattachAgentChatResult,
|
||||||
ReattachResult,
|
ReattachResult,
|
||||||
|
RestartCellAgentRuntimeInput,
|
||||||
|
RestartCellAgentRuntimeScheduled,
|
||||||
SendAgentChatOptions,
|
SendAgentChatOptions,
|
||||||
StoppedLiveAgent,
|
StoppedLiveAgent,
|
||||||
SystemGateway,
|
SystemGateway,
|
||||||
@ -221,6 +223,14 @@ export class HttpAgentGateway implements AgentGateway {
|
|||||||
request: { projectId, agentId, ...(reason ? { reason } : {}) },
|
request: { projectId, agentId, ...(reason ? { reason } : {}) },
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
restartCellAgentRuntime(
|
||||||
|
input: RestartCellAgentRuntimeInput,
|
||||||
|
): Promise<RestartCellAgentRuntimeScheduled> {
|
||||||
|
return this.http.invoke<RestartCellAgentRuntimeScheduled>(
|
||||||
|
"restart_cell_agent_runtime",
|
||||||
|
{ request: input },
|
||||||
|
);
|
||||||
|
}
|
||||||
createAgent(projectId: string, input: CreateAgentInput): Promise<Agent> {
|
createAgent(projectId: string, input: CreateAgentInput): Promise<Agent> {
|
||||||
return this.http.invoke<Agent>("create_agent", {
|
return this.http.invoke<Agent>("create_agent", {
|
||||||
request: {
|
request: {
|
||||||
|
|||||||
@ -164,6 +164,8 @@ import type {
|
|||||||
PluginWorkspaceWriteTextInput,
|
PluginWorkspaceWriteTextInput,
|
||||||
ReattachResult,
|
ReattachResult,
|
||||||
ReattachAgentChatResult,
|
ReattachAgentChatResult,
|
||||||
|
RestartCellAgentRuntimeInput,
|
||||||
|
RestartCellAgentRuntimeScheduled,
|
||||||
RemoteGateway,
|
RemoteGateway,
|
||||||
ReviewPluginPackageInput,
|
ReviewPluginPackageInput,
|
||||||
SetProjectPluginEnabledInput,
|
SetProjectPluginEnabledInput,
|
||||||
@ -406,6 +408,7 @@ export class MockAgentGateway implements AgentGateway {
|
|||||||
private contexts = new Map<string, string>();
|
private contexts = new Map<string, string>();
|
||||||
/** Monotonic session counter for deterministic session ids in tests. */
|
/** Monotonic session counter for deterministic session ids in tests. */
|
||||||
private sessionSeq = 0;
|
private sessionSeq = 0;
|
||||||
|
private restartSeq = 0;
|
||||||
/** Live agent PTY sessions, kept across detach so reattach can find them. */
|
/** Live agent PTY sessions, kept across detach so reattach can find them. */
|
||||||
private sessions = new Map<string, MockPtySession>();
|
private sessions = new Map<string, MockPtySession>();
|
||||||
/**
|
/**
|
||||||
@ -568,6 +571,37 @@ export class MockAgentGateway implements AgentGateway {
|
|||||||
return stopped;
|
return stopped;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
async restartCellAgentRuntime(
|
||||||
|
input: RestartCellAgentRuntimeInput,
|
||||||
|
): Promise<RestartCellAgentRuntimeScheduled> {
|
||||||
|
const known = this.getAgents(input.projectId).some(
|
||||||
|
(agent) => agent.id === input.agentId,
|
||||||
|
);
|
||||||
|
const sessionId = this.liveSessionByAgent.get(input.agentId);
|
||||||
|
if (!known || !sessionId) {
|
||||||
|
throw {
|
||||||
|
code: "RUNTIME_NOT_FOUND",
|
||||||
|
message: `agent ${input.agentId} has no live runtime`,
|
||||||
|
} as GatewayError;
|
||||||
|
}
|
||||||
|
if (this.liveByAgent.get(input.agentId) !== input.nodeId) {
|
||||||
|
throw {
|
||||||
|
code: "AGENT_NOT_BOUND_TO_CELL",
|
||||||
|
message: `agent ${input.agentId} is not bound to cell ${input.nodeId}`,
|
||||||
|
} as GatewayError;
|
||||||
|
}
|
||||||
|
this.restartSeq += 1;
|
||||||
|
return {
|
||||||
|
restartId: `mock-restart-${this.restartSeq}`,
|
||||||
|
status: "scheduled",
|
||||||
|
agentId: input.agentId,
|
||||||
|
nodeId: input.nodeId,
|
||||||
|
kind: this.liveKindByAgent.get(input.agentId) ?? "pty",
|
||||||
|
presentation: input.presentation,
|
||||||
|
layoutId: input.layoutId ?? null,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
async createAgent(projectId: string, input: CreateAgentInput): Promise<Agent> {
|
async createAgent(projectId: string, input: CreateAgentInput): Promise<Agent> {
|
||||||
const list = this.getAgents(projectId);
|
const list = this.getAgents(projectId);
|
||||||
const slug = slugify(input.name) || "agent";
|
const slug = slugify(input.name) || "agent";
|
||||||
|
|||||||
@ -6,7 +6,7 @@ import { describe, it, expect } from "vitest";
|
|||||||
|
|
||||||
import type { DomainEvent } from "@/domain";
|
import type { DomainEvent } from "@/domain";
|
||||||
import type { Gateways } from "@/ports";
|
import type { Gateways } from "@/ports";
|
||||||
import { createMockGateways, MockSystemGateway } from "./index";
|
import { createMockGateways, MockAgentGateway, MockSystemGateway } from "./index";
|
||||||
|
|
||||||
// Typechecking this assignment proves every mock implements its port.
|
// Typechecking this assignment proves every mock implements its port.
|
||||||
const gateways: Gateways = createMockGateways();
|
const gateways: Gateways = createMockGateways();
|
||||||
@ -90,6 +90,42 @@ describe("MockSystemGateway", () => {
|
|||||||
});
|
});
|
||||||
|
|
||||||
describe("other mock gateways", () => {
|
describe("other mock gateways", () => {
|
||||||
|
it("schedules a restart only for the agent runtime bound to the exact cell", async () => {
|
||||||
|
const agentGateway = new MockAgentGateway();
|
||||||
|
const agent = await agentGateway.createAgent("p1", {
|
||||||
|
name: "Worker",
|
||||||
|
profileId: "profile-1",
|
||||||
|
});
|
||||||
|
await agentGateway.launchAgent(
|
||||||
|
"p1",
|
||||||
|
agent.id,
|
||||||
|
{ cwd: "/p1", rows: 24, cols: 80, nodeId: "node-1" },
|
||||||
|
() => {},
|
||||||
|
);
|
||||||
|
|
||||||
|
await expect(
|
||||||
|
agentGateway.restartCellAgentRuntime({
|
||||||
|
projectId: "p1",
|
||||||
|
nodeId: "node-1",
|
||||||
|
agentId: agent.id,
|
||||||
|
presentation: "tui",
|
||||||
|
}),
|
||||||
|
).resolves.toMatchObject({
|
||||||
|
status: "scheduled",
|
||||||
|
agentId: agent.id,
|
||||||
|
nodeId: "node-1",
|
||||||
|
presentation: "tui",
|
||||||
|
});
|
||||||
|
await expect(
|
||||||
|
agentGateway.restartCellAgentRuntime({
|
||||||
|
projectId: "p1",
|
||||||
|
nodeId: "stale-node",
|
||||||
|
agentId: agent.id,
|
||||||
|
presentation: "tui",
|
||||||
|
}),
|
||||||
|
).rejects.toMatchObject({ code: "AGENT_NOT_BOUND_TO_CELL" });
|
||||||
|
});
|
||||||
|
|
||||||
it("project.createProject returns a project and listProjects reflects it", async () => {
|
it("project.createProject returns a project and listProjects reflects it", async () => {
|
||||||
expect(await gateways.project.listProjects()).toEqual([]);
|
expect(await gateways.project.listProjects()).toEqual([]);
|
||||||
const created = await gateways.project.createProject("n", "/root");
|
const created = await gateways.project.createProject("n", "/root");
|
||||||
|
|||||||
@ -286,6 +286,12 @@ export type AgentRestartPhase =
|
|||||||
| "launching"
|
| "launching"
|
||||||
| "resuming";
|
| "resuming";
|
||||||
|
|
||||||
|
export type AgentRestartFailureCode =
|
||||||
|
| "STOP_TIMEOUT"
|
||||||
|
| "STOP_FAILED"
|
||||||
|
| "LAUNCH_FAILED"
|
||||||
|
| "RESUME_FAILED";
|
||||||
|
|
||||||
export type DomainEvent =
|
export type DomainEvent =
|
||||||
| { type: "projectCreated"; projectId: string }
|
| { type: "projectCreated"; projectId: string }
|
||||||
| { type: "pluginInstalled"; pluginId: string; version: string }
|
| { type: "pluginInstalled"; pluginId: string; version: string }
|
||||||
@ -341,6 +347,7 @@ export type DomainEvent =
|
|||||||
agentId: string;
|
agentId: string;
|
||||||
restartId: string;
|
restartId: string;
|
||||||
phase: AgentRestartPhase;
|
phase: AgentRestartPhase;
|
||||||
|
code: AgentRestartFailureCode;
|
||||||
message: string;
|
message: string;
|
||||||
}
|
}
|
||||||
| {
|
| {
|
||||||
|
|||||||
@ -398,6 +398,7 @@ describe("CustomAgentChatView", () => {
|
|||||||
agentId: "agent-1",
|
agentId: "agent-1",
|
||||||
restartId: "restart-2",
|
restartId: "restart-2",
|
||||||
phase: "launching",
|
phase: "launching",
|
||||||
|
code: "LAUNCH_FAILED",
|
||||||
message: "runtime unavailable",
|
message: "runtime unavailable",
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
@ -361,6 +361,7 @@ describe("#288 — native TUI restart overlay", () => {
|
|||||||
agentId: "agent-T",
|
agentId: "agent-T",
|
||||||
restartId: "restart-2",
|
restartId: "restart-2",
|
||||||
phase: "launching",
|
phase: "launching",
|
||||||
|
code: "LAUNCH_FAILED",
|
||||||
message: "runtime unavailable",
|
message: "runtime unavailable",
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
@ -194,6 +194,183 @@ function expectedOperation(action: CellAction, cellId: string) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
describe("LayoutGrid — ticket #48 cell control layering", () => {
|
describe("LayoutGrid — ticket #48 cell control layering", () => {
|
||||||
|
it("shows restart only for an agent cell and disables its inputs while scheduled", async () => {
|
||||||
|
const setup = await makeSplitAgentGrid();
|
||||||
|
const restart = vi
|
||||||
|
.spyOn(setup.gateways.agent, "restartCellAgentRuntime")
|
||||||
|
.mockResolvedValue({
|
||||||
|
restartId: "restart-cell-1",
|
||||||
|
status: "scheduled",
|
||||||
|
agentId: setup.agentId,
|
||||||
|
nodeId: setup.bId,
|
||||||
|
kind: "pty",
|
||||||
|
presentation: "tui",
|
||||||
|
layoutId: null,
|
||||||
|
});
|
||||||
|
renderGrid(setup.gateways);
|
||||||
|
|
||||||
|
const button = await screen.findByRole("button", { name: "Redémarrer l’agent" });
|
||||||
|
expect(screen.getAllByRole("button", { name: "Redémarrer l’agent" })).toHaveLength(1);
|
||||||
|
fireEvent.click(button);
|
||||||
|
|
||||||
|
await waitFor(() =>
|
||||||
|
expect(restart).toHaveBeenCalledWith({
|
||||||
|
projectId: "p1",
|
||||||
|
nodeId: setup.bId,
|
||||||
|
agentId: setup.agentId,
|
||||||
|
presentation: "tui",
|
||||||
|
}),
|
||||||
|
);
|
||||||
|
expect(
|
||||||
|
(screen.getByRole("button", {
|
||||||
|
name: "Redémarrage de l’agent…",
|
||||||
|
}) as HTMLButtonElement).disabled,
|
||||||
|
).toBe(true);
|
||||||
|
expect(
|
||||||
|
(screen.getByLabelText(`agent selector ${setup.bId}`) as HTMLSelectElement)
|
||||||
|
.disabled,
|
||||||
|
).toBe(true);
|
||||||
|
expect(screen.getByText("Redémarrage de l’agent…")).toBeTruthy();
|
||||||
|
|
||||||
|
await flush();
|
||||||
|
act(() => {
|
||||||
|
setup.system.emit({
|
||||||
|
type: "agentRestartCompleted",
|
||||||
|
agentId: setup.agentId,
|
||||||
|
restartId: "restart-cell-1",
|
||||||
|
});
|
||||||
|
});
|
||||||
|
await waitFor(() =>
|
||||||
|
expect(
|
||||||
|
(screen.getByRole("button", {
|
||||||
|
name: "Redémarrer l’agent",
|
||||||
|
}) as HTMLButtonElement).disabled,
|
||||||
|
).toBe(false),
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("confirms a busy restart and forwards the custom CLI presentation", async () => {
|
||||||
|
const setup = await makeSplitAgentGrid();
|
||||||
|
window.localStorage.setItem(`idea.agent-cell-mode.p1.${setup.bId}`, "custom");
|
||||||
|
setup.workState._setProjectWorkState("p1", {
|
||||||
|
agents: [
|
||||||
|
{
|
||||||
|
agentId: setup.agentId,
|
||||||
|
name: "Worker",
|
||||||
|
profileId: "mock-claude",
|
||||||
|
busy: { state: "busy", sinceMs: 1 },
|
||||||
|
},
|
||||||
|
],
|
||||||
|
});
|
||||||
|
const restart = vi
|
||||||
|
.spyOn(setup.gateways.agent, "restartCellAgentRuntime")
|
||||||
|
.mockResolvedValue({
|
||||||
|
restartId: "restart-cell-2",
|
||||||
|
status: "scheduled",
|
||||||
|
agentId: setup.agentId,
|
||||||
|
nodeId: setup.bId,
|
||||||
|
kind: "structured",
|
||||||
|
presentation: "customCli",
|
||||||
|
layoutId: null,
|
||||||
|
});
|
||||||
|
renderGrid(setup.gateways);
|
||||||
|
|
||||||
|
fireEvent.click(await screen.findByRole("button", { name: "Redémarrer l’agent" }));
|
||||||
|
const dialog = await screen.findByRole("alertdialog", {
|
||||||
|
name: "Redémarrer l’agent ?",
|
||||||
|
});
|
||||||
|
expect(restart).not.toHaveBeenCalled();
|
||||||
|
fireEvent.click(screen.getByRole("button", { name: "Interrompre et redémarrer" }));
|
||||||
|
|
||||||
|
await waitFor(() =>
|
||||||
|
expect(restart).toHaveBeenCalledWith({
|
||||||
|
projectId: "p1",
|
||||||
|
nodeId: setup.bId,
|
||||||
|
agentId: setup.agentId,
|
||||||
|
presentation: "customCli",
|
||||||
|
}),
|
||||||
|
);
|
||||||
|
expect(dialog.isConnected).toBe(false);
|
||||||
|
window.localStorage.removeItem(`idea.agent-cell-mode.p1.${setup.bId}`);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("distinguishes an asynchronous relaunch failure and offers retry/close", async () => {
|
||||||
|
const setup = await makeSplitAgentGrid();
|
||||||
|
vi.spyOn(setup.gateways.agent, "restartCellAgentRuntime").mockResolvedValue({
|
||||||
|
restartId: "restart-cell-3",
|
||||||
|
status: "scheduled",
|
||||||
|
agentId: setup.agentId,
|
||||||
|
nodeId: setup.bId,
|
||||||
|
kind: "pty",
|
||||||
|
presentation: "tui",
|
||||||
|
layoutId: null,
|
||||||
|
});
|
||||||
|
renderGrid(setup.gateways);
|
||||||
|
fireEvent.click(await screen.findByRole("button", { name: "Redémarrer l’agent" }));
|
||||||
|
await flush();
|
||||||
|
|
||||||
|
act(() => {
|
||||||
|
setup.system.emit({
|
||||||
|
type: "agentRestartFailed",
|
||||||
|
agentId: setup.agentId,
|
||||||
|
restartId: "restart-cell-3",
|
||||||
|
phase: "launching",
|
||||||
|
code: "LAUNCH_FAILED",
|
||||||
|
message: "provider unavailable",
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(await screen.findByText("Impossible de relancer l’agent.")).toBeTruthy();
|
||||||
|
expect(screen.getByText("provider unavailable")).toBeTruthy();
|
||||||
|
expect(screen.getByRole("button", { name: "Réessayer" })).toBeTruthy();
|
||||||
|
fireEvent.click(screen.getByRole("button", { name: "Fermer" }));
|
||||||
|
expect(screen.queryByTestId("cell-agent-restart-state")).toBeNull();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("distinguishes an asynchronous stop failure", async () => {
|
||||||
|
const setup = await makeSplitAgentGrid();
|
||||||
|
vi.spyOn(setup.gateways.agent, "restartCellAgentRuntime").mockResolvedValue({
|
||||||
|
restartId: "restart-cell-stop",
|
||||||
|
status: "scheduled",
|
||||||
|
agentId: setup.agentId,
|
||||||
|
nodeId: setup.bId,
|
||||||
|
kind: "pty",
|
||||||
|
presentation: "tui",
|
||||||
|
layoutId: null,
|
||||||
|
});
|
||||||
|
renderGrid(setup.gateways);
|
||||||
|
fireEvent.click(await screen.findByRole("button", { name: "Redémarrer l’agent" }));
|
||||||
|
await flush();
|
||||||
|
|
||||||
|
act(() => {
|
||||||
|
setup.system.emit({
|
||||||
|
type: "agentRestartFailed",
|
||||||
|
agentId: setup.agentId,
|
||||||
|
restartId: "restart-cell-stop",
|
||||||
|
phase: "stopping",
|
||||||
|
code: "STOP_TIMEOUT",
|
||||||
|
message: "stop timed out",
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(await screen.findByText("Impossible d’arrêter l’agent.")).toBeTruthy();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("surfaces a synchronous typed binding error", async () => {
|
||||||
|
const setup = await makeSplitAgentGrid();
|
||||||
|
vi.spyOn(setup.gateways.agent, "restartCellAgentRuntime").mockRejectedValue({
|
||||||
|
code: "AGENT_NOT_BOUND_TO_CELL",
|
||||||
|
message: "stale cell binding",
|
||||||
|
});
|
||||||
|
renderGrid(setup.gateways);
|
||||||
|
fireEvent.click(await screen.findByRole("button", { name: "Redémarrer l’agent" }));
|
||||||
|
|
||||||
|
expect(
|
||||||
|
await screen.findByText("L’agent n’est plus associé à cette cellule."),
|
||||||
|
).toBeTruthy();
|
||||||
|
expect(screen.getByText("stale cell binding")).toBeTruthy();
|
||||||
|
});
|
||||||
|
|
||||||
it("keeps custom CLI mode controls compact inside the cell toolbar (#151)", async () => {
|
it("keeps custom CLI mode controls compact inside the cell toolbar (#151)", async () => {
|
||||||
const setup = await makeSplitAgentGrid();
|
const setup = await makeSplitAgentGrid();
|
||||||
|
|
||||||
|
|||||||
@ -275,6 +275,13 @@ interface PendingModeSwitch {
|
|||||||
target: AgentCellMode;
|
target: AgentCellMode;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
interface CellRestartState {
|
||||||
|
status: "running" | "failed";
|
||||||
|
restartId: string | null;
|
||||||
|
code?: string;
|
||||||
|
message?: string;
|
||||||
|
}
|
||||||
|
|
||||||
interface TrustedCustomCliBinding {
|
interface TrustedCustomCliBinding {
|
||||||
agent: Agent;
|
agent: Agent;
|
||||||
profile: AgentProfile;
|
profile: AgentProfile;
|
||||||
@ -382,6 +389,91 @@ function StoppedAgentCellPanel({
|
|||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
function restartFailureLabel(code?: string): string {
|
||||||
|
switch (code) {
|
||||||
|
case "STOP_TIMEOUT":
|
||||||
|
case "STOP_FAILED":
|
||||||
|
return "Impossible d’arrêter l’agent.";
|
||||||
|
case "LAUNCH_FAILED":
|
||||||
|
case "RESUME_FAILED":
|
||||||
|
return "Impossible de relancer l’agent.";
|
||||||
|
case "RUNTIME_NOT_FOUND":
|
||||||
|
return "Runtime de l’agent introuvable.";
|
||||||
|
case "AGENT_NOT_BOUND_TO_CELL":
|
||||||
|
return "L’agent n’est plus associé à cette cellule.";
|
||||||
|
case "CONFLICT_AGENT_VISIBLE_ELSEWHERE":
|
||||||
|
return "Cet agent est visible dans une autre cellule.";
|
||||||
|
case "CONFLICT":
|
||||||
|
return "Un redémarrage est déjà en cours pour cet agent.";
|
||||||
|
default:
|
||||||
|
return "Impossible de redémarrer l’agent.";
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
function CellAgentRestartOverlay({
|
||||||
|
state,
|
||||||
|
onRetry,
|
||||||
|
onClose,
|
||||||
|
}: {
|
||||||
|
state: CellRestartState;
|
||||||
|
onRetry: () => void;
|
||||||
|
onClose: () => void;
|
||||||
|
}) {
|
||||||
|
const failed = state.status === "failed";
|
||||||
|
return (
|
||||||
|
<div
|
||||||
|
data-testid="cell-agent-restart-state"
|
||||||
|
role={failed ? "alert" : "status"}
|
||||||
|
aria-live="polite"
|
||||||
|
style={{
|
||||||
|
position: "absolute",
|
||||||
|
inset: 0,
|
||||||
|
zIndex: failed ? CELL_Z.controls + 1 : CELL_Z.veil,
|
||||||
|
display: "flex",
|
||||||
|
alignItems: "center",
|
||||||
|
justifyContent: "center",
|
||||||
|
background: "rgba(0, 0, 0, 0.58)",
|
||||||
|
color: "var(--color-content, #e0e0e0)",
|
||||||
|
padding: 12,
|
||||||
|
pointerEvents: failed ? "auto" : "none",
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
<div
|
||||||
|
style={{
|
||||||
|
maxWidth: 420,
|
||||||
|
border: "1px solid var(--color-border, #3a3a3a)",
|
||||||
|
borderRadius: 6,
|
||||||
|
background: "var(--color-surface, #1e1e1e)",
|
||||||
|
padding: "8px 12px",
|
||||||
|
fontSize: 12,
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
<strong>
|
||||||
|
{failed ? restartFailureLabel(state.code) : "Redémarrage de l’agent…"}
|
||||||
|
</strong>
|
||||||
|
{failed && state.message && (
|
||||||
|
<p style={{ margin: "6px 0 0", color: "var(--color-muted, #9aa7b4)" }}>
|
||||||
|
{state.message}
|
||||||
|
</p>
|
||||||
|
)}
|
||||||
|
{failed && (
|
||||||
|
<div
|
||||||
|
style={{
|
||||||
|
display: "flex",
|
||||||
|
justifyContent: "flex-end",
|
||||||
|
gap: 8,
|
||||||
|
marginTop: 8,
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
<button type="button" onClick={onClose}>Fermer</button>
|
||||||
|
<button type="button" onClick={onRetry}>Réessayer</button>
|
||||||
|
</div>
|
||||||
|
)}
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Local z-index scale for a single cell (ticket #48). Intra-cell layering only —
|
* Local z-index scale for a single cell (ticket #48). Intra-cell layering only —
|
||||||
* unrelated to the global {@link zIndex} scale used for app-level surfaces.
|
* unrelated to the global {@link zIndex} scale used for app-level surfaces.
|
||||||
@ -769,6 +861,76 @@ function LeafView({
|
|||||||
const busyByWorkState = agentWork?.busy.state === "busy" || Boolean(activeTicket);
|
const busyByWorkState = agentWork?.busy.state === "busy" || Boolean(activeTicket);
|
||||||
const delegatedTicket = activeTicket?.source.kind === "agent" ? activeTicket : undefined;
|
const delegatedTicket = activeTicket?.source.kind === "agent" ? activeTicket : undefined;
|
||||||
const busyActive = announcementBusyActive || busyByWorkState;
|
const busyActive = announcementBusyActive || busyByWorkState;
|
||||||
|
const [cellRestart, setCellRestart] = useState<CellRestartState | null>(null);
|
||||||
|
const cellRestartRef = useRef<CellRestartState | null>(null);
|
||||||
|
const cellRestartRequestRef = useRef(0);
|
||||||
|
const cellRestartOwnedIdRef = useRef<string | null>(null);
|
||||||
|
const [restartConfirmationOpen, setRestartConfirmationOpen] = useState(false);
|
||||||
|
const cellRestartBusy = cellRestart?.status === "running";
|
||||||
|
const otherRestartActive = Boolean(
|
||||||
|
agentRestart && agentRestart.restartId !== cellRestartOwnedIdRef.current,
|
||||||
|
);
|
||||||
|
const cellIdentity = `${projectId}:${layoutId ?? ""}:${id}:${agentId ?? ""}`;
|
||||||
|
const cellIdentityRef = useRef(cellIdentity);
|
||||||
|
const previousCellIdentityRef = useRef(cellIdentity);
|
||||||
|
cellIdentityRef.current = cellIdentity;
|
||||||
|
|
||||||
|
const commitCellRestart = (next: CellRestartState | null) => {
|
||||||
|
cellRestartRef.current = next;
|
||||||
|
setCellRestart(next);
|
||||||
|
};
|
||||||
|
|
||||||
|
useEffect(() => {
|
||||||
|
if (previousCellIdentityRef.current === cellIdentity) return;
|
||||||
|
previousCellIdentityRef.current = cellIdentity;
|
||||||
|
cellRestartRequestRef.current += 1;
|
||||||
|
cellRestartOwnedIdRef.current = null;
|
||||||
|
commitCellRestart(null);
|
||||||
|
setRestartConfirmationOpen(false);
|
||||||
|
}, [cellIdentity]);
|
||||||
|
|
||||||
|
async function restartCellAgent(): Promise<void> {
|
||||||
|
if (!agentId || !agentGateway || cellRestartRef.current?.status === "running") return;
|
||||||
|
const requestIdentity = cellIdentity;
|
||||||
|
const sequence = ++cellRestartRequestRef.current;
|
||||||
|
cellRestartOwnedIdRef.current = null;
|
||||||
|
const running: CellRestartState = { status: "running", restartId: null };
|
||||||
|
commitCellRestart(running);
|
||||||
|
setRestartConfirmationOpen(false);
|
||||||
|
try {
|
||||||
|
const scheduled = await agentGateway.restartCellAgentRuntime({
|
||||||
|
projectId,
|
||||||
|
nodeId: id,
|
||||||
|
agentId,
|
||||||
|
presentation: cellMode === "custom" ? "customCli" : "tui",
|
||||||
|
...(layoutId ? { layoutId } : {}),
|
||||||
|
});
|
||||||
|
if (
|
||||||
|
cellRestartRequestRef.current === sequence &&
|
||||||
|
cellIdentityRef.current === requestIdentity
|
||||||
|
) {
|
||||||
|
cellRestartOwnedIdRef.current = scheduled.restartId;
|
||||||
|
commitCellRestart({ status: "running", restartId: scheduled.restartId });
|
||||||
|
}
|
||||||
|
} catch (error) {
|
||||||
|
if (
|
||||||
|
cellRestartRequestRef.current === sequence &&
|
||||||
|
cellIdentityRef.current === requestIdentity
|
||||||
|
) {
|
||||||
|
commitCellRestart({
|
||||||
|
status: "failed",
|
||||||
|
restartId: null,
|
||||||
|
code: gatewayErrorCode(error),
|
||||||
|
message: describeNotice(error),
|
||||||
|
});
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
function requestCellAgentRestart(): void {
|
||||||
|
if (busyActive) setRestartConfirmationOpen(true);
|
||||||
|
else void restartCellAgent();
|
||||||
|
}
|
||||||
const targetAnnouncementsFallback = delegatedTicket?.requesterLabel
|
const targetAnnouncementsFallback = delegatedTicket?.requesterLabel
|
||||||
? `Travaille sur une demande de ${delegatedTicket.requesterLabel}.`
|
? `Travaille sur une demande de ${delegatedTicket.requesterLabel}.`
|
||||||
: "Travaille sur une demande en cours.";
|
: "Travaille sur une demande en cours.";
|
||||||
@ -1042,6 +1204,84 @@ function LeafView({
|
|||||||
// eslint-disable-next-line react-hooks/exhaustive-deps
|
// eslint-disable-next-line react-hooks/exhaustive-deps
|
||||||
}, [liveAgents, agentId, session]);
|
}, [liveAgents, agentId, session]);
|
||||||
|
|
||||||
|
useEffect(() => {
|
||||||
|
if (!system || !agentId) return;
|
||||||
|
let cancelled = false;
|
||||||
|
let unsubscribe: (() => void) | undefined;
|
||||||
|
void system
|
||||||
|
.onDomainEvent((event) => {
|
||||||
|
if (
|
||||||
|
event.type !== "agentRestartRequested" &&
|
||||||
|
event.type !== "agentRestartPhaseChanged" &&
|
||||||
|
event.type !== "agentRestartCompleted" &&
|
||||||
|
event.type !== "agentRestartFailed"
|
||||||
|
) return;
|
||||||
|
if (event.agentId !== agentId) return;
|
||||||
|
const current = cellRestartRef.current;
|
||||||
|
if (!current || current.status !== "running") return;
|
||||||
|
if (event.type === "agentRestartRequested") {
|
||||||
|
if (!current.restartId) {
|
||||||
|
cellRestartOwnedIdRef.current = event.restartId;
|
||||||
|
commitCellRestart({ ...current, restartId: event.restartId });
|
||||||
|
}
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
if (
|
||||||
|
event.type !== "agentRestartCompleted" &&
|
||||||
|
event.type !== "agentRestartFailed"
|
||||||
|
) return;
|
||||||
|
if (current.restartId && current.restartId !== event.restartId) return;
|
||||||
|
|
||||||
|
if (event.type === "agentRestartFailed") {
|
||||||
|
cellRestartOwnedIdRef.current = event.restartId;
|
||||||
|
commitCellRestart({
|
||||||
|
status: "failed",
|
||||||
|
restartId: event.restartId,
|
||||||
|
code: event.code,
|
||||||
|
message: event.message,
|
||||||
|
});
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
commitCellRestart(null);
|
||||||
|
void (async () => {
|
||||||
|
const live = await agentGateway?.listLiveAgents(projectId);
|
||||||
|
if (cancelled || !live) return;
|
||||||
|
setLiveAgents(live);
|
||||||
|
const restarted = live.find((entry) => entry.agentId === agentId);
|
||||||
|
if (
|
||||||
|
restarted?.kind === "pty" &&
|
||||||
|
restarted.sessionId &&
|
||||||
|
restarted.sessionId !== session
|
||||||
|
) {
|
||||||
|
await vm.attachLiveAgentToCell(
|
||||||
|
id,
|
||||||
|
agentId,
|
||||||
|
restarted.sessionId,
|
||||||
|
);
|
||||||
|
if (!cancelled) setAttachGen((generation) => generation + 1);
|
||||||
|
}
|
||||||
|
await refreshWorkState();
|
||||||
|
})().catch(() => {
|
||||||
|
// The restart itself completed; lifecycle refresh remains best-effort.
|
||||||
|
});
|
||||||
|
})
|
||||||
|
.then((un) => {
|
||||||
|
if (cancelled) un();
|
||||||
|
else unsubscribe = un;
|
||||||
|
})
|
||||||
|
.catch(() => {
|
||||||
|
// The synchronous command error remains visible if events are unavailable.
|
||||||
|
});
|
||||||
|
return () => {
|
||||||
|
cancelled = true;
|
||||||
|
unsubscribe?.();
|
||||||
|
};
|
||||||
|
// The subscription follows the exact visible cell identity. Runtime refresh
|
||||||
|
// functions are deliberately read from that render until the identity changes.
|
||||||
|
// eslint-disable-next-line react-hooks/exhaustive-deps
|
||||||
|
}, [system, agentGateway, projectId, layoutId, id, agentId]);
|
||||||
|
|
||||||
// ── Cell routing (Option 1 — Terminal + MCP) ──────────────────────────────
|
// ── Cell routing (Option 1 — Terminal + MCP) ──────────────────────────────
|
||||||
// Every agent cell renders the raw {@link TerminalView}: the human view is the
|
// Every agent cell renders the raw {@link TerminalView}: the human view is the
|
||||||
// native interactive PTY (live reasoning + Échap are native CLI behaviours,
|
// native interactive PTY (live reasoning + Échap are native CLI behaviours,
|
||||||
@ -1143,6 +1383,7 @@ function LeafView({
|
|||||||
<select
|
<select
|
||||||
aria-label={`agent selector ${id}`}
|
aria-label={`agent selector ${id}`}
|
||||||
value={agentId ?? ""}
|
value={agentId ?? ""}
|
||||||
|
disabled={cellRestartBusy}
|
||||||
onChange={(e) => {
|
onChange={(e) => {
|
||||||
const val = e.target.value;
|
const val = e.target.value;
|
||||||
if (val === "") {
|
if (val === "") {
|
||||||
@ -1230,6 +1471,7 @@ function LeafView({
|
|||||||
>
|
>
|
||||||
<button
|
<button
|
||||||
type="button"
|
type="button"
|
||||||
|
disabled={cellRestartBusy}
|
||||||
aria-pressed={cellMode === "tui"}
|
aria-pressed={cellMode === "tui"}
|
||||||
title="TUI native"
|
title="TUI native"
|
||||||
onClick={() => requestMode("tui")}
|
onClick={() => requestMode("tui")}
|
||||||
@ -1257,6 +1499,7 @@ function LeafView({
|
|||||||
</button>
|
</button>
|
||||||
<button
|
<button
|
||||||
type="button"
|
type="button"
|
||||||
|
disabled={cellRestartBusy}
|
||||||
aria-pressed={cellMode === "custom"}
|
aria-pressed={cellMode === "custom"}
|
||||||
title="CLI custom"
|
title="CLI custom"
|
||||||
onClick={() => requestMode("custom")}
|
onClick={() => requestMode("custom")}
|
||||||
@ -1284,6 +1527,18 @@ function LeafView({
|
|||||||
</div>
|
</div>
|
||||||
)}
|
)}
|
||||||
|
|
||||||
|
{agentId && (
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
title={cellRestartBusy ? "Redémarrage de l’agent…" : "Redémarrer l’agent"}
|
||||||
|
aria-label={cellRestartBusy ? "Redémarrage de l’agent…" : "Redémarrer l’agent"}
|
||||||
|
disabled={cellRestartBusy}
|
||||||
|
onClick={requestCellAgentRestart}
|
||||||
|
>
|
||||||
|
↻
|
||||||
|
</button>
|
||||||
|
)}
|
||||||
|
|
||||||
<button
|
<button
|
||||||
type="button"
|
type="button"
|
||||||
title="Split into columns"
|
title="Split into columns"
|
||||||
@ -1467,7 +1722,8 @@ function LeafView({
|
|||||||
is being injected into the agent's PTY, a grey veil with a centred
|
is being injected into the agent's PTY, a grey veil with a centred
|
||||||
message sits above the terminal. Only ever shown for an agent cell —
|
message sits above the terminal. Only ever shown for an agent cell —
|
||||||
and never together with the F3 overlay (exactly one veil, F3 first). */}
|
and never together with the F3 overlay (exactly one veil, F3 first). */}
|
||||||
{!agentRestart &&
|
{!cellRestart &&
|
||||||
|
!otherRestartActive &&
|
||||||
!modelServerOverlay &&
|
!modelServerOverlay &&
|
||||||
cellMode !== "custom" &&
|
cellMode !== "custom" &&
|
||||||
shouldShowWritePortalVeil(agentId != null, Boolean(overlay), busyActive) && (
|
shouldShowWritePortalVeil(agentId != null, Boolean(overlay), busyActive) && (
|
||||||
@ -1506,7 +1762,7 @@ function LeafView({
|
|||||||
an availability veil showing its live réflexions. Native TUI cells
|
an availability veil showing its live réflexions. Native TUI cells
|
||||||
need the full-cell guard; custom CLI cells keep the canonical busy
|
need the full-cell guard; custom CLI cells keep the canonical busy
|
||||||
badge and composer lock only, matching their normal chat turn flow. */}
|
badge and composer lock only, matching their normal chat turn flow. */}
|
||||||
{!agentRestart && !modelServerOverlay && cellMode !== "custom" && agentId != null && (
|
{!cellRestart && !otherRestartActive && !modelServerOverlay && cellMode !== "custom" && agentId != null && (
|
||||||
<TargetAnnouncementsOverlay
|
<TargetAnnouncementsOverlay
|
||||||
projectId={projectId}
|
projectId={projectId}
|
||||||
agentId={agentId}
|
agentId={agentId}
|
||||||
@ -1519,7 +1775,7 @@ function LeafView({
|
|||||||
agent's bound local server is downloading its model / starting /
|
agent's bound local server is downloading its model / starting /
|
||||||
probing, the empty terminal is covered rather than left to time out.
|
probing, the empty terminal is covered rather than left to time out.
|
||||||
Retracts at `ready`/`failed` (the predicate returns null then). */}
|
Retracts at `ready`/`failed` (the predicate returns null then). */}
|
||||||
{!agentRestart && modelServerOverlay && (
|
{!cellRestart && !otherRestartActive && modelServerOverlay && (
|
||||||
<div
|
<div
|
||||||
data-testid="model-server-overlay"
|
data-testid="model-server-overlay"
|
||||||
role="status"
|
role="status"
|
||||||
@ -1636,9 +1892,19 @@ function LeafView({
|
|||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
)}
|
)}
|
||||||
{cellMode !== "custom" && agentId != null && agentRestart && (
|
{!cellRestart &&
|
||||||
|
cellMode !== "custom" &&
|
||||||
|
agentId != null &&
|
||||||
|
otherRestartActive && (
|
||||||
<AgentRestartOverlay agentId={agentId} />
|
<AgentRestartOverlay agentId={agentId} />
|
||||||
)}
|
)}
|
||||||
|
{cellRestart && (
|
||||||
|
<CellAgentRestartOverlay
|
||||||
|
state={cellRestart}
|
||||||
|
onRetry={() => void restartCellAgent()}
|
||||||
|
onClose={() => commitCellRestart(null)}
|
||||||
|
/>
|
||||||
|
)}
|
||||||
</div>
|
</div>
|
||||||
{busyNotice && (
|
{busyNotice && (
|
||||||
<div
|
<div
|
||||||
@ -1769,6 +2035,58 @@ function LeafView({
|
|||||||
</div>
|
</div>
|
||||||
</div>
|
</div>
|
||||||
)}
|
)}
|
||||||
|
{restartConfirmationOpen && (
|
||||||
|
<div
|
||||||
|
role="alertdialog"
|
||||||
|
aria-modal="true"
|
||||||
|
aria-label="Redémarrer l’agent ?"
|
||||||
|
style={{
|
||||||
|
position: "absolute",
|
||||||
|
inset: 0,
|
||||||
|
zIndex: CELL_Z.controls + 1,
|
||||||
|
display: "flex",
|
||||||
|
alignItems: "center",
|
||||||
|
justifyContent: "center",
|
||||||
|
background: "rgba(0, 0, 0, 0.62)",
|
||||||
|
padding: 12,
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
<div
|
||||||
|
style={{
|
||||||
|
width: 360,
|
||||||
|
maxWidth: "100%",
|
||||||
|
border: "1px solid var(--color-border, #3a3a3a)",
|
||||||
|
borderRadius: 6,
|
||||||
|
background: "var(--color-surface, #1e1e1e)",
|
||||||
|
color: "var(--color-content, #e0e0e0)",
|
||||||
|
padding: 12,
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
<h2 style={{ margin: 0, fontSize: 14 }}>Redémarrer l’agent ?</h2>
|
||||||
|
<p style={{ margin: "8px 0 0", fontSize: 12 }}>
|
||||||
|
L’activité en cours sera interrompue avant la relance de l’agent.
|
||||||
|
</p>
|
||||||
|
<div
|
||||||
|
style={{
|
||||||
|
display: "flex",
|
||||||
|
justifyContent: "flex-end",
|
||||||
|
gap: 8,
|
||||||
|
marginTop: 12,
|
||||||
|
}}
|
||||||
|
>
|
||||||
|
<button
|
||||||
|
type="button"
|
||||||
|
onClick={() => setRestartConfirmationOpen(false)}
|
||||||
|
>
|
||||||
|
Annuler
|
||||||
|
</button>
|
||||||
|
<button type="button" onClick={() => void restartCellAgent()}>
|
||||||
|
Interrompre et redémarrer
|
||||||
|
</button>
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
</div>
|
||||||
|
)}
|
||||||
</div>
|
</div>
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
@ -2022,6 +2340,13 @@ function describeNotice(e: unknown): string {
|
|||||||
return String(e);
|
return String(e);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
function gatewayErrorCode(e: unknown): string | undefined {
|
||||||
|
if (e && typeof e === "object" && "code" in e) {
|
||||||
|
return String((e as { code: unknown }).code);
|
||||||
|
}
|
||||||
|
return undefined;
|
||||||
|
}
|
||||||
|
|
||||||
/** True when `e` is the backend singleton-invariant refusal (`GatewayError`). */
|
/** True when `e` is the backend singleton-invariant refusal (`GatewayError`). */
|
||||||
function isAlreadyRunning(e: unknown): boolean {
|
function isAlreadyRunning(e: unknown): boolean {
|
||||||
return (
|
return (
|
||||||
|
|||||||
@ -232,6 +232,26 @@ export interface ReattachAgentChatOptions {
|
|||||||
agentId?: string;
|
agentId?: string;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
export type CellAgentPresentation = "headless" | "tui" | "customCli" | "unknown";
|
||||||
|
|
||||||
|
export interface RestartCellAgentRuntimeInput {
|
||||||
|
projectId: string;
|
||||||
|
nodeId: string;
|
||||||
|
agentId: string;
|
||||||
|
presentation: CellAgentPresentation;
|
||||||
|
layoutId?: string;
|
||||||
|
}
|
||||||
|
|
||||||
|
export interface RestartCellAgentRuntimeScheduled {
|
||||||
|
restartId: string;
|
||||||
|
status: "scheduled";
|
||||||
|
agentId: string;
|
||||||
|
nodeId: string;
|
||||||
|
kind: "pty" | "structured";
|
||||||
|
presentation: CellAgentPresentation;
|
||||||
|
layoutId: string | null;
|
||||||
|
}
|
||||||
|
|
||||||
/** Agents: create, list, read/update context, delete, launch (L6). */
|
/** Agents: create, list, read/update context, delete, launch (L6). */
|
||||||
export interface AgentGateway {
|
export interface AgentGateway {
|
||||||
/** Lists all agents belonging to the given project. */
|
/** Lists all agents belonging to the given project. */
|
||||||
@ -269,6 +289,10 @@ export interface AgentGateway {
|
|||||||
* commands from the Work panel. The backend owns the live-agent lifecycle.
|
* commands from the Work panel. The backend owns the live-agent lifecycle.
|
||||||
*/
|
*/
|
||||||
stopLiveAgent(projectId: string, agentId: string, reason?: string): Promise<StoppedLiveAgent>;
|
stopLiveAgent(projectId: string, agentId: string, reason?: string): Promise<StoppedLiveAgent>;
|
||||||
|
/** Atomically stops and relaunches the runtime bound to one visible agent cell. */
|
||||||
|
restartCellAgentRuntime(
|
||||||
|
input: RestartCellAgentRuntimeInput,
|
||||||
|
): Promise<RestartCellAgentRuntimeScheduled>;
|
||||||
/** Creates a new agent from scratch; returns the created agent. */
|
/** Creates a new agent from scratch; returns the created agent. */
|
||||||
createAgent(projectId: string, input: CreateAgentInput): Promise<Agent>;
|
createAgent(projectId: string, input: CreateAgentInput): Promise<Agent>;
|
||||||
/**
|
/**
|
||||||
|
|||||||
Reference in New Issue
Block a user