blomios/IdeA
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(plugins): hot reload des plugins sans relancer IdeA — use case ReloadPlugin (invalidation registry/catalogue, resultat hashes+changed), tools MCP d'administration plugin agent-facing (mcp/plugins.rs + PluginToolProvider), evenement domaine plugin_reloaded relaye sur le wire (dto/events), exposition openai_tools rafraichie, wiring app-tauri — #271/#269 (QA verte #273: application 32, mcp_server 38, openai_tools 10, plugin_install_load 5, plugin 10, wire 1 — 96 tests ciblés; app-tauri compile sans desktop runtime)

Browse Source
This commit is contained in:
Blomios
2026-09-07 19:29:25 +02:00
parent 8d2be75f8f
commit 805b1b4d0d
14 changed files with 863 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

101
crates/backend/src/openai_tools.rs
View File

@ -14,6 +14,7 @@ use domain::ports::{
ToolSpec,
};
use domain::{AgentToolPolicy, IssueRef, McpToolPolicy, Project};
use infrastructure::orchestrator::mcp::PluginToolProvider;
use infrastructure::{ManagedTempToolProvider, TemplateToolProvider, TicketToolProvider};
use serde_json::Value;
@ -29,6 +30,7 @@ pub struct AppOpenAiToolInvoker {
ticket_tools: Arc<dyn TicketToolProvider>,
template_tools: Arc<dyn TemplateToolProvider>,
managed_temp_tools: Arc<dyn ManagedTempToolProvider>,
plugin_tools: Arc<dyn PluginToolProvider>,
}
/// Proxy injecté avant que l'orchestrateur soit construit, puis lié dans la
@ -103,6 +105,7 @@ impl AppOpenAiToolInvoker {
ticket_tools: Arc<dyn TicketToolProvider>,
template_tools: Arc<dyn TemplateToolProvider>,
managed_temp_tools: Arc<dyn ManagedTempToolProvider>,
plugin_tools: Arc<dyn PluginToolProvider>,
) -> Self {
Self {
orchestrator,
@ -112,6 +115,7 @@ impl AppOpenAiToolInvoker {
ticket_tools,
template_tools,
managed_temp_tools,
plugin_tools,
}
}
}
@ -232,6 +236,19 @@ impl ToolInvoker for AppOpenAiToolInvoker {
ToolInvocationError::Execution(format!("JSON managed temp tool: {e}"))
});
}
if infrastructure::orchestrator::mcp::tools::is_plugin_tool(name) {
let value = self
.plugin_tools
.handle_plugin_tool(&project, &requester, name, value)
.await
.map_err(|e| {
let detail =
serde_json::to_string(&e.to_value()).unwrap_or_else(|_| e.to_string());
ToolInvocationError::Execution(detail)
})?;
return serde_json::to_string(&value)
.map_err(|e| ToolInvocationError::Execution(format!("JSON plugin tool: {e}")));
}
let command = infrastructure::orchestrator::mcp::map_tool_call(name, &value, &requester)
.map_err(|e| match e {
infrastructure::orchestrator::mcp::ToolMapError::UnknownTool(tool) => {
@ -424,6 +441,7 @@ mod tests {
AgentId, AgentMcpToolPolicyOverride, McpToolPolicy, Project, ProjectId,
ProjectMcpToolPermissions, ProjectPath, RemoteRef, StoreError, Workspace,
};
use infrastructure::orchestrator::mcp::PluginToolError;
use infrastructure::{ManagedTempToolError, TemplateToolError, TicketToolError};
use serde_json::json;
use uuid::Uuid;
@ -606,6 +624,36 @@ mod tests {
Arc::new(FakeManagedTempTools::default())
}
#[derive(Default)]
struct FakePluginTools {
calls: Mutex<Vec<(String, String, Value)>>,
}
#[async_trait]
impl PluginToolProvider for FakePluginTools {
async fn handle_plugin_tool(
&self,
_project: &Project,
requester: &str,
name: &str,
arguments: Value,
) -> Result<Value, PluginToolError> {
self.calls.lock().unwrap().push((
requester.to_owned(),
name.to_owned(),
arguments.clone(),
));
Ok(json!({
"pluginId": arguments.get("pluginId").and_then(Value::as_str).unwrap_or_default(),
"changed": true,
}))
}
}
fn fake_plugin_tools() -> Arc<FakePluginTools> {
Arc::new(FakePluginTools::default())
}
fn issue_ref(raw: &str) -> IssueRef {
IssueRef::from_str(raw).unwrap()
}
@ -772,6 +820,7 @@ mod tests {
ticket_tools.clone(),
template_tools,
fake_managed_temp_tools(),
fake_plugin_tools(),
);
let denied = invoker
@ -838,6 +887,7 @@ mod tests {
ticket_tools.clone(),
template_tools.clone(),
fake_managed_temp_tools(),
fake_plugin_tools(),
);
for tool in ["idea_ticket_list", "idea_template_list"] {
@ -928,6 +978,7 @@ mod tests {
Arc::new(FakeTicketTools::default()),
Arc::new(FakeTemplateTools::default()),
fake_managed_temp_tools(),
fake_plugin_tools(),
);
let tools = invoker
@ -968,6 +1019,7 @@ mod tests {
Arc::new(FakeTicketTools::default()),
Arc::new(FakeTemplateTools::default()),
fake_managed_temp_tools(),
fake_plugin_tools(),
);
let tools = invoker
@ -1001,6 +1053,7 @@ mod tests {
ticket_tools.clone(),
template_tools,
fake_managed_temp_tools(),
fake_plugin_tools(),
);
let result = invoker
@ -1048,6 +1101,7 @@ mod tests {
ticket_tools,
template_tools.clone(),
fake_managed_temp_tools(),
fake_plugin_tools(),
);
let result = invoker
@ -1095,4 +1149,51 @@ mod tests {
let _ = std::fs::remove_dir_all(temp);
}
#[tokio::test]
async fn openai_explicit_plugin_reload_permission_routes_to_plugin_provider() {
let temp = std::env::temp_dir().join(format!(
"idea-openai-plugin-reload-permissions-{}",
Uuid::new_v4()
));
let core = crate::BackendCore::build(temp.clone());
let agent = AgentId::from_uuid(Uuid::from_u128(271));
let requester = agent.to_string();
let plugin_tools = fake_plugin_tools();
let invoker = AppOpenAiToolInvoker::new(
Arc::clone(&core.orchestrator_service),
Arc::new(FakeProjects::with(project())) as Arc<dyn ProjectStore>,
Arc::new(FakePolicies::default()),
mcp_permissions(allow_doc(agent, &["idea_plugin_reload"])),
Arc::new(FakeTicketTools::default()),
Arc::new(FakeTemplateTools::default()),
fake_managed_temp_tools(),
plugin_tools.clone(),
);
let result = invoker
.call(
"idea_plugin_reload",
&json!({
PROJECT_ROOT_ARG: "/tmp/project",
REQUESTER_ARG: requester,
"pluginId": "dev.acme.gitgraph",
"expectedContentHash": "abc123",
})
.to_string(),
)
.await
.expect("explicit durable override should reach plugin provider");
let result: Value = serde_json::from_str(&result).unwrap();
assert_eq!(result["pluginId"], "dev.acme.gitgraph");
assert_eq!(result["changed"], true);
let calls = plugin_tools.calls.lock().unwrap();
assert_eq!(calls.len(), 1);
assert_eq!(calls[0].0, requester);
assert_eq!(calls[0].1, "idea_plugin_reload");
assert_eq!(calls[0].2["expectedContentHash"], "abc123");
let _ = std::fs::remove_dir_all(temp);
}
}