fix(cli): progress agent_message émis en live + anti-doublon running/done par progressId — #187 (QA verte)
- Codex: les items agent_message sont désormais tapés en live comme progress (Message/Delta) dès item.completed, au lieu d'être bufferisés dans pending_final jusqu'à l'événement tool/MCP suivant. - Corrélation stable progressId (codex:item:<id>) ajoutée sur ReplyProgress, propagée jusqu'au DTO (ReplyProgressDto.progressId) et au frontend ; le ProgressSettler et la vue procèdent par upsert running -> done au lieu d'empiler des lignes dupliquées. - Tests: chat_bridge (settler par progressId), dto_chat, session codex, CustomAgentChatView (upsert par progressId).
This commit is contained in:
@ -1016,6 +1016,7 @@ mod tests {
|
||||
&& progress.stage == ReplyProgressStage::Completed
|
||||
&& progress.label == "reasoning"
|
||||
&& progress.tool_name.as_deref() == Some("reasoning")
|
||||
&& progress.progress_id.as_deref() == Some("codex:item:i0")
|
||||
),
|
||||
"reasoning item must be represented by one canonical progress event: {:?}",
|
||||
r.events
|
||||
@ -1032,6 +1033,7 @@ mod tests {
|
||||
&& progress.stage == ReplyProgressStage::Completed
|
||||
&& progress.label == "command"
|
||||
&& progress.tool_name.as_deref() == Some("command")
|
||||
&& progress.progress_id.as_deref() == Some("codex:item:i1")
|
||||
),
|
||||
"command item must be represented by one canonical progress event: {:?}",
|
||||
c.events
|
||||
@ -1055,6 +1057,7 @@ mod tests {
|
||||
&& progress.label == "read_file"
|
||||
&& progress.tool_name.as_deref() == Some("read_file")
|
||||
&& progress.native_event.as_deref() == Some("conversation.item.added")
|
||||
&& progress.progress_id.as_deref() == Some("codex:item:call_1")
|
||||
),
|
||||
"Codex item.added must surface tool start immediately: {:?}",
|
||||
r.events
|
||||
@ -1083,6 +1086,7 @@ mod tests {
|
||||
&& progress.label == "idea_ask_agent"
|
||||
&& progress.tool_name.as_deref() == Some("idea_ask_agent")
|
||||
&& progress.native_event.as_deref() == Some("conversation.item.added")
|
||||
&& progress.progress_id.as_deref() == Some("codex:item:call_1")
|
||||
),
|
||||
"Codex MCP tool start must be tagged as IdeaLocal/Mcp: {:?}",
|
||||
r.events
|
||||
@ -1106,6 +1110,7 @@ mod tests {
|
||||
&& progress.label == "idea_ask_agent"
|
||||
&& progress.tool_name.as_deref() == Some("idea_ask_agent")
|
||||
&& progress.native_event.as_deref() == Some("conversation.item.done")
|
||||
&& progress.progress_id.as_deref() == Some("codex:item:call_1")
|
||||
),
|
||||
"Codex MCP tool completion must keep the real tool name: {:?}",
|
||||
r.events
|
||||
@ -1436,12 +1441,20 @@ mod tests {
|
||||
matches!(live.first(), Some(ReplyEvent::Progress { progress }) if progress.native_event.as_deref() == Some("turn.started")),
|
||||
"le démarrage du tour provider doit être tapé live en premier"
|
||||
);
|
||||
let announcement_idx = live
|
||||
let message_idx = live
|
||||
.iter()
|
||||
.position(
|
||||
|event| matches!(event, ReplyEvent::Announcement { text } if text == "je délègue"),
|
||||
)
|
||||
.expect("l'annonce d'intention doit être tapée live");
|
||||
.position(|event| {
|
||||
matches!(
|
||||
event,
|
||||
ReplyEvent::Progress { progress }
|
||||
if progress.source == ReplyProgressSource::ProviderNative
|
||||
&& progress.kind == ReplyProgressKind::Message
|
||||
&& progress.stage == ReplyProgressStage::Delta
|
||||
&& progress.text.as_deref() == Some("je délègue")
|
||||
&& progress.progress_id.as_deref() == Some("codex:item:i0")
|
||||
)
|
||||
})
|
||||
.expect("le message agent doit être tapé live comme progress");
|
||||
let mcp_idx = live
|
||||
.iter()
|
||||
.position(|event| {
|
||||
@ -1456,8 +1469,8 @@ mod tests {
|
||||
})
|
||||
.expect("le début MCP doit être tapé live");
|
||||
assert!(
|
||||
announcement_idx < mcp_idx,
|
||||
"l'annonce d'intention doit précéder le premier MCP dans le tap live: {:?}",
|
||||
message_idx < mcp_idx,
|
||||
"le message agent doit précéder le premier MCP dans le tap live: {:?}",
|
||||
live
|
||||
);
|
||||
assert!(
|
||||
|
||||
Reference in New Issue
Block a user