feat(backend): domaine + catalogue et store durable des permissions tools MCP (#82 lot B1)

Introduit le domaine mcp_tool_permissions (règles de permission par tool
MCP) et étend le port de store correspondant. Le catalogue read/write des
tools MCP (orchestrator/mcp/tools.rs) s'appuie désormais sur ces règles, et
un store durable (mcp_tool_permission.rs) persiste les permissions au-delà
d'une session.

Lot B1 du ticket #82 : pose le socle domaine/store, l'enforcement suit en
B2 sur la même branche.

QA vert.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

crates/infrastructure/src/lib.rs

@@ -99,8 +99,8 @@ pub use store::{
     embedder_from_profile, index_token_size, onnx_model_is_cached, should_use_vector,
     AdaptiveMemoryRecall, BackgroundTaskReconcileReport, EmbedderEnvProbe, FsBackgroundTaskStore,
     FsDeviceSessionStore, FsEmbedderProfileStore, FsEmbedderPromptStore, FsLiveStateStore,
-    FsMemoryStore, FsPermissionStore, FsProfileStore, FsProjectStore, FsSkillStore,
-    FsTemplateStore, FsWindowStateStore, HashEmbedder, IdeaiContextStore, NaiveMemoryRecall,
-    OnnxModelInfo, StubEmbedder, VectorMemoryRecall, DEFAULT_OLLAMA_BASE_URL, ONNX_CACHE_SUBDIR,
-    RECOMMENDED_ONNX_MODELS, VECTOR_HTTP_ENABLED, VECTOR_ONNX_ENABLED,
+    FsMcpToolPermissionStore, FsMemoryStore, FsPermissionStore, FsProfileStore, FsProjectStore,
+    FsSkillStore, FsTemplateStore, FsWindowStateStore, HashEmbedder, IdeaiContextStore,
+    NaiveMemoryRecall, OnnxModelInfo, StubEmbedder, VectorMemoryRecall, DEFAULT_OLLAMA_BASE_URL,
+    ONNX_CACHE_SUBDIR, RECOMMENDED_ONNX_MODELS, VECTOR_HTTP_ENABLED, VECTOR_ONNX_ENABLED,
 };

crates/infrastructure/src/orchestrator/mcp/tools.rs

@@ -34,6 +34,70 @@ pub struct ToolDef {
     pub input_schema: Value,
 }
 
+/// Coarse MCP tool access class used to derive default permissions.
+#[derive(Debug, Clone, Copy, PartialEq, Eq)]
+pub enum McpToolAccess {
+    /// Read-only application capability, allowed by default.
+    Read,
+    /// Write/action/execution capability, denied by default.
+    WriteAction,
+}
+
+/// Canonical read-only MCP tools allowed by default.
+pub const READ_ONLY_TOOLS: &[&str] = &[
+    "idea_list_agents",
+    "idea_context_read",
+    "idea_memory_read",
+    "idea_skill_read",
+    "idea_workstate_read",
+    "idea_ticket_read",
+    "idea_ticket_list",
+    "idea_ticket_read_carnet",
+    "idea_sprint_list",
+];
+
+/// Canonical write/action MCP tools denied by default.
+pub const WRITE_ACTION_TOOLS: &[&str] = &[
+    "idea_ask_agent",
+    "idea_run_in_background",
+    "idea_launch_agent",
+    "idea_stop_agent",
+    "idea_update_context",
+    "idea_context_propose",
+    "idea_memory_write",
+    "idea_workstate_set",
+    "idea_create_skill",
+    "idea_ticket_create",
+    "idea_ticket_update",
+    "idea_ticket_update_status",
+    "idea_ticket_update_priority",
+    "idea_ticket_update_carnet",
+    "idea_ticket_link",
+    "idea_ticket_unlink",
+];
+
+/// All MCP tool names that have an explicit access classification.
+#[must_use]
+pub fn classified_tool_names() -> Vec<&'static str> {
+    READ_ONLY_TOOLS
+        .iter()
+        .chain(WRITE_ACTION_TOOLS.iter())
+        .copied()
+        .collect()
+}
+
+/// Returns the explicit access class for `tool`.
+#[must_use]
+pub fn tool_access(tool: &str) -> Option<McpToolAccess> {
+    if READ_ONLY_TOOLS.contains(&tool) {
+        Some(McpToolAccess::Read)
+    } else if WRITE_ACTION_TOOLS.contains(&tool) {
+        Some(McpToolAccess::WriteAction)
+    } else {
+        None
+    }
+}
+
 /// Errors mapping a tool call into a validated [`OrchestratorCommand`].
 #[derive(Debug, thiserror::Error, PartialEq, Eq)]
 pub enum ToolMapError {
@@ -498,6 +562,7 @@ fn optional_u64(value: Option<&Value>, tool: &str) -> Result<Option<u64>, ToolMa
 mod tests {
     use super::*;
     use domain::OrchestratorVisibility;
+    use std::collections::HashSet;
 
     /// A well-formed handshake requester id for the tests (parsed as an `AgentId`).
     const REQ: &str = "11111111-1111-1111-1111-111111111111";
@@ -507,6 +572,44 @@ mod tests {
         map_tool_call(name, args, "")
     }
 
+    #[test]
+    fn catalogue_tools_have_explicit_read_or_write_access() {
+        let catalogue_names = catalogue()
+            .into_iter()
+            .map(|tool| tool.name)
+            .collect::<HashSet<_>>();
+
+        for tool in &catalogue_names {
+            assert!(
+                tool_access(tool).is_some(),
+                "MCP catalogue tool `{tool}` must choose Read or WriteAction explicitly"
+            );
+        }
+
+        for tool in classified_tool_names() {
+            assert!(
+                catalogue_names.contains(tool),
+                "classified MCP tool `{tool}` is not advertised by the catalogue"
+            );
+        }
+    }
+
+    #[test]
+    fn read_and_write_tool_classifications_are_disjoint_and_unique() {
+        let mut seen = HashSet::new();
+        for tool in READ_ONLY_TOOLS {
+            assert!(seen.insert(*tool), "duplicate read-only MCP tool `{tool}`");
+            assert_eq!(tool_access(tool), Some(McpToolAccess::Read));
+        }
+        for tool in WRITE_ACTION_TOOLS {
+            assert!(
+                seen.insert(*tool),
+                "MCP tool `{tool}` is classified more than once"
+            );
+            assert_eq!(tool_access(tool), Some(McpToolAccess::WriteAction));
+        }
+    }
+
     #[test]
     fn ask_agent_maps_to_headless_inter_agent_command_but_reply_stays_hidden() {
         let requester = uuid::Uuid::from_u128(42).to_string();

crates/infrastructure/src/store/mcp_tool_permission.rs

@@ -0,0 +1,81 @@
+//! Filesystem-backed [`McpToolPermissionStore`] for project MCP tool permissions.
+
+use std::sync::Arc;
+
+use async_trait::async_trait;
+
+use domain::ports::{FileSystem, FsError, McpToolPermissionStore, RemotePath, StoreError};
+use domain::{Project, ProjectMcpToolPermissions};
+
+use crate::orchestrator::mcp::tools;
+
+const MCP_TOOL_PERMISSIONS_FILE: &str = "mcp-tool-permissions.json";
+
+/// JSON-file implementation for `<project>/.ideai/mcp-tool-permissions.json`.
+#[derive(Clone)]
+pub struct FsMcpToolPermissionStore {
+    fs: Arc<dyn FileSystem>,
+}
+
+impl FsMcpToolPermissionStore {
+    /// Builds the store from an injected filesystem port.
+    #[must_use]
+    pub fn new(fs: Arc<dyn FileSystem>) -> Self {
+        Self { fs }
+    }
+
+    fn path(project: &Project) -> RemotePath {
+        let root = project.root.as_str().trim_end_matches(['/', '\\']);
+        RemotePath::new(format!("{root}/.ideai/{MCP_TOOL_PERMISSIONS_FILE}"))
+    }
+
+    async fn ensure_ideai(&self, project: &Project) -> Result<(), StoreError> {
+        let root = project.root.as_str().trim_end_matches(['/', '\\']);
+        self.fs
+            .create_dir_all(&RemotePath::new(format!("{root}/.ideai")))
+            .await
+            .map_err(|e| StoreError::Io(e.to_string()))
+    }
+
+    fn validate(permissions: &ProjectMcpToolPermissions) -> Result<(), StoreError> {
+        let known_tools = tools::classified_tool_names();
+        permissions
+            .validate(&known_tools)
+            .map_err(|e| StoreError::Serialization(e.to_string()))
+    }
+}
+
+#[async_trait]
+impl McpToolPermissionStore for FsMcpToolPermissionStore {
+    async fn load_mcp_tool_permissions(
+        &self,
+        project: &Project,
+    ) -> Result<ProjectMcpToolPermissions, StoreError> {
+        match self.fs.read(&Self::path(project)).await {
+            Ok(bytes) => {
+                let permissions = serde_json::from_slice::<ProjectMcpToolPermissions>(&bytes)
+                    .map_err(|e| StoreError::Serialization(e.to_string()))?;
+                Self::validate(&permissions)?;
+                Ok(permissions)
+            }
+            Err(FsError::NotFound(_)) => Ok(ProjectMcpToolPermissions::default()),
+            Err(e) => Err(StoreError::Io(e.to_string())),
+        }
+    }
+
+    async fn save_mcp_tool_permissions(
+        &self,
+        project: &Project,
+        permissions: &ProjectMcpToolPermissions,
+    ) -> Result<(), StoreError> {
+        Self::validate(permissions)?;
+        self.ensure_ideai(project).await?;
+        let mut bytes = serde_json::to_vec_pretty(permissions)
+            .map_err(|e| StoreError::Serialization(e.to_string()))?;
+        bytes.push(b'\n');
+        self.fs
+            .write(&Self::path(project), &bytes)
+            .await
+            .map_err(|e| StoreError::Io(e.to_string()))
+    }
+}

crates/infrastructure/src/store/mod.rs

@@ -9,6 +9,7 @@ mod context;
 mod device_session;
 mod embedder;
 mod live_state;
+mod mcp_tool_permission;
 mod memory;
 mod permission;
 mod profile;
@@ -31,6 +32,7 @@ pub use embedder::{
     RECOMMENDED_ONNX_MODELS, VECTOR_HTTP_ENABLED, VECTOR_ONNX_ENABLED,
 };
 pub use live_state::FsLiveStateStore;
+pub use mcp_tool_permission::FsMcpToolPermissionStore;
 pub use memory::{index_token_size, FsMemoryStore, NaiveMemoryRecall};
 pub use permission::FsPermissionStore;
 pub use profile::{FsEmbedderProfileStore, FsProfileStore};

crates/infrastructure/tests/mcp_tool_permission_store.rs

@@ -0,0 +1,176 @@
+//! L2 integration tests for [`FsMcpToolPermissionStore`] against a real temp project.
+
+use std::path::PathBuf;
+use std::sync::Arc;
+
+use domain::ids::{AgentId, ProjectId};
+use domain::ports::{FileSystem, McpToolPermissionStore, StoreError};
+use domain::project::{Project, ProjectPath};
+use domain::remote::RemoteRef;
+use domain::{
+    AgentMcpToolPolicyOverride, McpToolPolicy, ProjectMcpToolPermissions,
+    MCP_TOOL_PERMISSIONS_VERSION,
+};
+use infrastructure::orchestrator::mcp::tools::{classified_tool_names, READ_ONLY_TOOLS};
+use infrastructure::{FsMcpToolPermissionStore, LocalFileSystem};
+use uuid::Uuid;
+
+/// A unique scratch project directory under the OS temp dir, cleaned up on drop.
+struct TempDir(PathBuf);
+
+impl TempDir {
+    fn new() -> Self {
+        let p =
+            std::env::temp_dir().join(format!("idea-l2-mcp-tool-permissions-{}", Uuid::new_v4()));
+        std::fs::create_dir_all(&p).unwrap();
+        Self(p)
+    }
+
+    fn project_root(&self) -> String {
+        self.0.to_string_lossy().into_owned()
+    }
+}
+
+impl Drop for TempDir {
+    fn drop(&mut self) {
+        let _ = std::fs::remove_dir_all(&self.0);
+    }
+}
+
+fn store() -> FsMcpToolPermissionStore {
+    let fs: Arc<dyn FileSystem> = Arc::new(LocalFileSystem::new());
+    FsMcpToolPermissionStore::new(fs)
+}
+
+fn project(tmp: &TempDir) -> Project {
+    Project::new(
+        ProjectId::new_random(),
+        "mcp-tool-permissions",
+        ProjectPath::new(tmp.project_root()).unwrap(),
+        RemoteRef::local(),
+        1_700_000_000_000,
+    )
+    .unwrap()
+}
+
+fn policy(tools: &[&str]) -> McpToolPolicy {
+    McpToolPolicy::new(
+        tools.iter().map(|tool| (*tool).to_owned()).collect(),
+        &classified_tool_names(),
+    )
+    .unwrap()
+}
+
+#[tokio::test]
+async fn missing_mcp_tool_permissions_file_returns_default_document() {
+    let tmp = TempDir::new();
+    let project = project(&tmp);
+
+    let loaded = store().load_mcp_tool_permissions(&project).await.unwrap();
+
+    assert_eq!(loaded, ProjectMcpToolPermissions::default());
+    assert_eq!(loaded.version, MCP_TOOL_PERMISSIONS_VERSION);
+
+    let effective = loaded
+        .effective_policy(
+            AgentId::new_random(),
+            READ_ONLY_TOOLS,
+            &classified_tool_names(),
+        )
+        .unwrap();
+    assert!(effective.permits("idea_context_read"));
+    assert!(!effective.permits("idea_memory_write"));
+}
+
+#[tokio::test]
+async fn save_then_load_roundtrips_project_default_and_agent_override() {
+    let tmp = TempDir::new();
+    let project = project(&tmp);
+    let agent = AgentId::new_random();
+    let doc = ProjectMcpToolPermissions::new(
+        Some(policy(&["idea_context_read", "idea_memory_read"])),
+        vec![AgentMcpToolPolicyOverride::new(
+            agent,
+            policy(&["idea_ticket_update"]),
+        )],
+        &classified_tool_names(),
+    )
+    .unwrap();
+
+    let store = store();
+    store
+        .save_mcp_tool_permissions(&project, &doc)
+        .await
+        .unwrap();
+
+    let loaded = store.load_mcp_tool_permissions(&project).await.unwrap();
+    assert_eq!(loaded, doc);
+
+    let effective = loaded
+        .effective_policy(agent, READ_ONLY_TOOLS, &classified_tool_names())
+        .unwrap();
+    assert!(effective.permits("idea_ticket_update"));
+    assert!(!effective.permits("idea_context_read"));
+
+    let path = tmp.0.join(".ideai").join("mcp-tool-permissions.json");
+    assert!(
+        path.exists(),
+        "store writes under .ideai/mcp-tool-permissions.json"
+    );
+}
+
+#[tokio::test]
+async fn load_rejects_unknown_tool_permissions() {
+    let tmp = TempDir::new();
+    let project = project(&tmp);
+    let path = tmp.0.join(".ideai").join("mcp-tool-permissions.json");
+    std::fs::create_dir_all(path.parent().unwrap()).unwrap();
+    std::fs::write(
+        path,
+        r#"{
+  "version": 1,
+  "projectDefault": { "allowedTools": ["idea_unknown"] },
+  "agents": []
+}
+"#,
+    )
+    .unwrap();
+
+    let err = store()
+        .load_mcp_tool_permissions(&project)
+        .await
+        .unwrap_err();
+
+    assert!(
+        matches!(err, StoreError::Serialization(ref message) if message.contains("unknown MCP tool: idea_unknown")),
+        "unknown tools must not become latent permissions, got {err:?}"
+    );
+}
+
+#[tokio::test]
+async fn save_rejects_invalid_allowlist_before_writing() {
+    let tmp = TempDir::new();
+    let project = project(&tmp);
+    let invalid = ProjectMcpToolPermissions {
+        version: MCP_TOOL_PERMISSIONS_VERSION,
+        project_default: Some(McpToolPolicy {
+            allowed_tools: vec!["idea_unknown".to_owned()],
+        }),
+        agents: Vec::new(),
+    };
+
+    let err = store()
+        .save_mcp_tool_permissions(&project, &invalid)
+        .await
+        .unwrap_err();
+
+    assert!(
+        matches!(err, StoreError::Serialization(ref message) if message.contains("unknown MCP tool: idea_unknown")),
+        "invalid allowlists must be rejected before persistence, got {err:?}"
+    );
+    assert!(!tmp
+        .0
+        .join(".ideai")
+        .join("mcp-tool-permissions.json")
+        .exists());
+}